search

Tejas1510 / Athavani

😻 Athavani/Memories is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years.
https://athavani.vercel.app
MIT License
37 stars 113 forks source link

Loading bar issue Has been resolved issue no. 343 #343 #347

Open heet-kumar opened 3 years ago

heet-kumar commented 3 years ago

issue no. 343 #343 I have removed the loading bar which appear on the Log-In and Sign-up buttons while clicking on that . It does not look attractive to the users for their experience .

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @Tejas1510 on Vercel.

@Tejas1510 first needs to authorize it.

ChitvanRamani22 commented 3 years ago

@heet-kumar is the server not working issue resolved in this pr itself?

heet-kumar commented 3 years ago

yes resolved about the Loading bar

heet-kumar commented 3 years ago

@ChitvanRamani22 loading bar issue resolved

ChitvanRamani22 commented 3 years ago

@heet-kumar i m asking about that server error?

heet-kumar commented 3 years ago

@heet-kumar i m asking about that server error?

server error it is showing its god because when your network is down that time it shows Server Not responding . Btw here I am getting server is not responding because this website is running on my Localhost if it hosted on any platform and connected to the Database then this Server is not Responding will not appear .

heet-kumar commented 3 years ago

@heet-kumar i m asking about that server error?

server error it is showing its god because when your network is down that time it shows Server Not responding . Btw here I am getting server is not responding because this website is running on my Localhost if it hosted on any platform and connected to the Database then this Server is not Responding will not appear .

@ChitvanRamani22 check this above one commit

heet-kumar commented 3 years ago

@heet-kumar Buddy it would be nice if in the description you mention the issue number and also include the screenshots of how it was before and how it is now It will be easy for you as well as for us

done sir I apologies for inconvenience .

before it is : Screenshot (707)

here in the above I have given intentionally random/correct email id dosen't matter I have checked that in both email id , but the loading bar appears on the sign-in and sign-up buttons that dosen't looks good that issue I have resolved .

heet-kumar commented 3 years ago

After resolving the issue : note : this issue appears only on clicking on the buttons . Screenshot (706)

heet-kumar commented 3 years ago

@heet-kumar Buddy tell me one thing , I agree that loading bar doesn't look good when the email is wrong or something like that. But what in the case where the credentials are right , in that case also the loading bar will not appear as you have removed the import line and also that " LinearProgress " component

Other than this , what I think is : " Server is not responding " error is not occuring like you said : in the localhost its appearing ,but in the deployed version , it will not show Its not like that , if server is not running , whether its localhost or deployed version , it will not run But if it's running it will be running both in localhost and deployed version. So I think you need to understand this , leme know if you have any doubts or something

@Jassi10000 bro don't mind it I have just want to let you know that already error features are there like if credentials are correct then it will not display any type of error in the below white space or If credential are wrong then It will display type of that particular error in below white space given .

I apologies if you mind it .

Jassi10000-zz commented 3 years ago

@heet-kumar No buddy , not an issue btw any changes u tried to made ?

heet-kumar commented 3 years ago

@Jassi10000 No I didn't found any another way to resolve it I think in my point of view which I have provided that is correct . Thank you for your patience towards this issue .

Jassi10000-zz commented 3 years ago

@Jassi10000 No I didn't found any another way to resolve it I think in my point of view which I have provided that is correct . Thank you for your patience towards this issue .

Buddy , it would be nice if you come on a meet , let' continue the further convo on discord

heet-kumar commented 3 years ago

@Jassi10000 ya Sure brother why not

Jassi10000-zz commented 3 years ago

@Jassi10000 ya Sure brother why not

Jassi | M#8109 <-- discord username

heet-kumar commented 3 years ago

@Tejas1510 @sanjay270899 @Jassi10000 I am facing an issue that : the loading bar visible at the bottom of the login button is still loading even when the credentials are right and is not allowing me to navigate me to other pages . Admin and mentors pls have a look at this problem

Jassi10000-zz commented 3 years ago

@Tejas1510 @sanjay270899 @Jassi10000 I am facing an issue that : the loading bar visible at the bottom of the login button is still loading even when the credentials are right and is not allowing me to navigate me to other pages . Admin and mentors pls have a look at this problem

Sure , @heet-kumar we will have a look over this