search

TekNoLogic / GnomishVendorShrinker

WoW Addon - Compact scrolling vendor frame
http://www.tekkub.net/addons
29 stars 20 forks source link

Update to 8.0 #55

Open Shauren opened 6 years ago

Shauren commented 6 years ago

Also fixed that old annoyance with resetting scroll after buying items

Closes #51 Closes #54

bradxeno commented 6 years ago

Testing both fixes, zero issues so far.

DarkVirtue commented 6 years ago

The fixes are working well for me, too.

ckaotik commented 6 years ago

Ah, so that's why the texts sometimes go missing. Thanks for figuring that out!

Myrroddin commented 6 years ago

Line 35 of ui-scrollbar.lua in the externals folder must be changed to the following. Er, this is before any other applied fixes. PlaySoundKit(SOUNDKIT.UChatScrollButton)

spiralofhope commented 5 years ago

Could you please also check out these commits:

  1. https://github.com/TekNoLogic/GnomishVendorShrinker/pull/56/commits/e62f58f300e304e17b0200828f865850d25076ba

  2. https://github.com/TekNoLogic/GnomishVendorShrinker/pull/56/commits/f48fc9c5d21ee4f44adf32ad6a69d5cc5d27b375

  3. https://github.com/TekNoLogic/GnomishVendorShrinker/pull/56/commits/fbdf467ab17650afd123231e6b822589765fb5c6

  4. frames\QtyPopout.lua from:

OpenStackSplitFrame(250, self, "LEFT", "RIGHT")

to:

StackSplitFrame:OpenStackSplitFrame(250, self, "LEFT", "RIGHT")
  1. https://github.com/TekNoLogic/GnomishVendorShrinker/pull/56#issuecomment-408531103

    Line 35 of ui-scrollbar.lua in the externals folder must be changed to PlaySoundKit(SOUNDKIT.UChatScrollButton)

I have made all of your changes, and also these five more, and they all seem to work.