search

TekkaGB / AemulusModManager

GNU General Public License v3.0
79 stars 20 forks source link

Fix crash extracting p5r switch #105

Closed AnimatedSwine37 closed 4 days ago

AnimatedSwine37 commented 2 months ago

When unpacking the base files for P5R Switch (and maybe other games, not sure) you could get a null argument exception. This is because fileList.Contains(filePath) is being run when filePath is null, this shouldn't happen because the check for extractAll should be first.

oceanstuck commented 2 months ago

Just saw this now, minor correction that it's not filePath that's null (it should always be set directly before this check), it's fileList which is assigned for every game except P5R Switch (extractAll is set to true when fileList is null). I know this because I wrote that entire function 💀 my bad

SirGamers commented 1 month ago

Oh man, they are finally fixing #95, I finally will be able to update my Aemulus install

I wrote that entire function 💀 my bad

yea you messed up, ocean