Closed Jai-2001 closed 1 year ago
Tried out this pr but it just made Aemulus much laggier, thus I deleted these changes that were previously merged
Could you elaborate as to where this discovered lag would have been found?
Testing the run time for building and merging has shown for me a considerable increase in performance, this build includes a version of P3HD overhaul for which the prior versions have suffered the greatest slow-down:
Build time on the debug build of the fork:
Build time on the release version of the fork:
Build time on the release of master made before the fix:
Additionally, the new logging system did solve a bug in the application, where the window would freeze and potentially cause a not responding dialogue to appear, caused by massive batches of print calls occurring in the GUI thread.
The second commit in this fork also fixes an issue that has been affected a chunk of P3 mods in which it became impossible to make use of GB's 1-click install because aemulus wouldn't be able to extract the mod correctly.
@Jai-2001 For me as can be seen here, Aemulus won't even make it pass initialization and my cpu temps were getting really high.
I can remove the parallel logger and keep the path fix and it no longer freezes on me
Functions with high numbers of logged messages were causing bottlenecks by blocking until each message was printed, this fork implements a utility class to push these messages to another thread, freeing file operations from being bound by console IO.