search

Tekki / mojo-mysql

Mojolicious and Async MySQL
0 stars 0 forks source link

Extended JSON support #1

Open Tekki opened 5 years ago

Tekki commented 5 years ago

This is planned as the next step for SQL::Abstract::mysql. @jhthorsen what do you think of it? Take a look at the docs and the tests. There are some live tests too.

jhthorsen commented 5 years ago

Is this something you still want feedback on..? Could you open up a PR if you have reached a point where you think it should be merged?

Tekki commented 5 years ago

a) yes, b) yes I've seen that you started to use 'note' in the tests. I'll have to do some work to make the tests here look the same.

jhthorsen commented 5 years ago

Could you send me a link like https://github.com/jhthorsen/mojo-mysql/compare/master...Tekki:json-dev so it can be easier for me to compare/read the changes you've done?

It's not a big deal if you use "note" or not in the tests. I'm not even sure if it's a good idea - though I don't see any harm in doing so.

(There seems to be a lot of files/diff that is not core for this issue)

Tekki commented 5 years ago

This is a development branch that contains a lot of other stuff. My question was more about the concept. But I'll prepare a new branch and a PR.

jhthorsen commented 5 years ago

I’m positive in general to changes where the user of a module needs to do less 👍

...but I have to see the change before making a final decision.