search

TeleIO / Telemachus-1

MIT License
34 stars 19 forks source link

Kerbalism and Telemachus reborn antenna power use #13

Open tomimas opened 5 years ago

tomimas commented 5 years ago

KSP 1.6.1 Kerbalism: 1.2.1 (https://github.com/steamp0rt/Kerbalism) Telemachus 1.6.22.F2

I don't know if this is an issue or a feature, but the power use of antennas is rather hefty, when these two mods are combined. Part says 1.8/min, but Kerbalism says 12.020/s. Everything is fine when only either one is installed.

Just OKTO

Telemachus uses some sort of antenna bitRate (factor of per thousands) to calculate it's power need. First I thought this is somewhat expected until I investigated it further. Maybe Kerbalism uses same sort of technique. Because, simply adding a single HG-5 Relay Antenna to the OKTO causes the power use to be over 50/s. So double multiplication is happening somewhere. I have no clue, what can and cannot be done with mods. Could it be possible to introduce somewhere that if Telemachus is installed use only Kerbalism power use calculations?

I did contact the the other modder also, as I would like to see these two awesome mods to be able to work together, and now are not.

SirMortimer commented 5 years ago

I won't look at this until #12 is fixed.

StoneBlue commented 4 years ago

I won't look at this until #12 is fixed.

Seems to be fixed nao. Dont know if the issue with Kerbalism is still valid, tho? vOv

SirMortimer commented 4 years ago

Loos good to me now. Seems to be fixed with Kerbalism 3.2 (probably 3.1, maybe even 3.0) See https://github.com/Kerbalism/Kerbalism/issues/373#issuecomment-567559327

sidrus commented 4 years ago

Should I close this ticket? From the previous comments, it seems like this is resolved.

StoneBlue commented 4 years ago

I'll take a look at this in the next couple days, to see if its still an issue with the latest Telemachus, and mebbe we can close it

StoneBlue commented 4 years ago

So I did try to look at this about a week ago. I couldnt find an easy way to isolate specific EC usage as far as the Kerbalism vs Telemachus antennas go. Granted, I am a Kerbalism noob, and have hardly ever used the mod, much less lately.

There were a few issues, that I think are related to "stock" Telemachus that should probably be looked at first, IMHO, before investigating compatability with support for other mods.

Not to discourage anyone from posting any info, details, or behaviour that they see with this Kerbalism issue, that either to confirm it still is an issue, or details that mihgt help point to what the issue could be.