search

TeleIO / Telemachus-1

MIT License
34 stars 19 forks source link

Various display issues with sensor readings #51

Closed Row-Bear closed 4 years ago

Row-Bear commented 4 years ago

Telemachus 1.7.64

-Temperature is displayed as Celsius on the webpage, but the value shown is in Kelvin. -Temperature shows 3 decimal places on webpage, in game has 2 -The G-Force and Acceleration sensor output show 5 decimal places, the sensors in game show 2 decimals

image

Row-Bear commented 4 years ago

Update to add: the pressure sensor data is also displayed incorrectly. KSP shows the data in kPa, Telemachus uses Pa as unit and divides the value by 1000. So, 100.1 kPa in game gets reported in Telemachus as 0.1001 Pa

StoneBlue commented 4 years ago

Not sure if this is the best ticket to post this to, but... It seems depending on what resource tanks/capacities are actually present on the craft, or NOT, this is what gets displayed for empty/non-existant tanks/capacities: resources display -1.00000 for resource tanks not present on craft resources display 0.00000 for resource tanks present but empty

Probably not a big deal, just an FYI incase someone wants to address it.

Row-Bear commented 4 years ago

I'll make a PR to set the decimals to 2, as that is actually used. The 0 / -1 issue is a bit more complex and will require bigger changes that would be better done after some overhauls Sidrus is planning

sidrus commented 4 years ago

@Row-Bear looks like your latest PR will close this ticket. I've linked it and will merge the the PR. Thanks for the help!