search

Telecominfraproject / ols-ucentral-schema

OpenLAN/Shasta contribution repo
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Move port-isolation schema from ethernet.yml to switch.yml #12

Closed Cahb closed 7 months ago

Cahb commented 7 months ago

port-isolation is a global configuration and should be described in switch.yml, not in ethernet.yml No changes were made to any of the fields.

Cahb commented 7 months ago

I guess it's the description of the commit that might be confusing; However, this config should be in switch, in my opinion: port-isolation is a switch feature, that is configured directly in ASIC to forbit traffic forwarding from X port to Y port.

But, if you think it should be moved to globals - it's not an issue for us to fixup this?

mikehansen1970 commented 7 months ago

I guess it's the description of the commit that might be confusing; However, this config should be in switch, in my opinion: port-isolation is a switch feature, that is configured directly in ASIC to forbit traffic forwarding from X port to Y port.

But, if you think it should be moved to globals - it's not an issue for us to fixup this?

No need to put in globals, I just meant it would have been my first instinct, to move it there. Sorry for the confusion.