Closed mikehansen1970 closed 2 months ago
Hey @mikehansen1970, i'm thinking right now what would be the appropriate 'dash'-styling on the naming convention stuff? I see we mostly stick to '-' style, but in this PR the "_" (underscore) is used; Is this something we have to formalize as well maybe?
UPD: Here's an example:
delta_counters
in current PR, vs some other entries / object definitions use:
"mesh-path": {
Hey @mikehansen1970, i'm thinking right now what would be the appropriate 'dash'-styling on the naming convention stuff? I see we mostly stick to '-' style, but in this PR the "_" (underscore) is used; Is this something we have to formalize as well maybe?
UPD: Here's an example:
delta_counters
in current PR, vs some other entries / object definitions use:
"mesh-path": {
Hi Oleksandr, I agree in principal with the '-' approach. However, I was trying to match the way that deltacounters are defined in the wlan-ucentral-schema, where an '' is used as it might be even worse to have 2 different names for what is essentially a shared value. https://github.com/Telecominfraproject/wlan-ucentral-schema/tree/main/state
What do you think?
Mike
Hi Mike, Thanks for your reply;
I see where it goes now. I think we could address this in the future (prepare PRs for OWGW / schema changes, as well as for ucentral clients; also mirror changes for OLS).
As of now, i think we can merge PR safely to not stop progress / overall work on the OLS stuff.
@mikehansen1970 you can merge whenever ready;
Add delta_counters to
state/interface.yml
state/link-state.yml