search

Telecominfraproject / oopt-gnpy

Optical Route Planning Library, Based on a Gaussian Noise Model
http://telecominfraproject.com
BSD 3-Clause "New" or "Revised" License
204 stars 88 forks source link

Test coverage of Raman simulation #282

Open jktjkt opened 5 years ago

jktjkt commented 5 years ago

Hi @aleFerrari , the Raman simulation is currently not covered by automated tests (this is visible in the coverage report saying "*codecov/project 65.59% (-13.82%) compared to 71d6a11**).

It would be nice if there is a simple test checking that the simulation engine works well. I think that the scenario should be kept reasonably simple, with just a few signals being checked and with a simplified topology (just one link). I'll be happy to help.

aleFerrari commented 5 years ago

Ok, I will do it. If it is ok will fork from the develop branch.

cgkelly commented 3 years ago

I have tried the Raman simulation by defining a RamanFiber span, and defining the Raman pump powers and frequencies. I get the expected Raman gain, but I do not see any gain ripple due to the spacing of the Raman pumps. (I'm not seeing any gain ripple in general, but this is a broader topic even for EDFA only spans that I'm looking into).

jktjkt commented 3 years ago

I have tried the Raman simulation by defining a RamanFiber span, and defining the Raman pump powers and frequencies. I get the expected Raman gain, but I do not see any gain ripple due to the spacing of the Raman pumps. (I'm not seeing any gain ripple in general, but this is a broader topic even for EDFA only spans that I'm looking into).

@cgkelly , I've created a bugreport for this at https://github.com/Telecominfraproject/oopt-gnpy/issues/398 .