search

Telefonica / mistica-design

Mística Design System (only design)
https://brandfactory.telefonica.com/mistica
20 stars 4 forks source link

Vivo: themer issues in dark mode #1802

Closed MontseTelefonica closed 3 days ago

MontseTelefonica commented 3 weeks ago

Describe the bug

Then using themer for Vivo new y vivo old, chips are not working properly in dark mode. Also the constant "background" is not working in dark mode. Maybe there are other issues but these are the ones I identified. https://www.figma.com/design/7oGfCcnzS1okDr2xyRIE54/Entrypoints?node-id=5156-107328&t=IUdnDadiL8rC7Vgi-4

image

What libraries are you seeing the problem on?

No response

Steps to reproduce

Add add a chip over a "background" background Apply themer Vivo(new) dark mode and Vivo dark mode

Expected behavior

Correct color aplication

yceballost commented 2 weeks ago

Vivo is not using Dark Mode theme

MontseTelefonica commented 2 weeks ago

We know, but the CMS has dark mode prop for all brands and we detect these kind of things :)

aweell commented 2 weeks ago

This bug should no be related to dark mode, the underlying problem is that textActivated and textBrand are not updated in Themer JSON and are not changing between brands. We changed recently the chips to use this two tokens.

All brands should be updated in Themer to solve the issue