Telefonica / mistica-web

React components library for Telefonica Design System (Mistica)
https://mistica-web.now.sh
MIT License
50 stars 10 forks source link

FixedToTop #1080

Open pladaria opened 5 months ago

pladaria commented 5 months ago

Current implementation

The ThemeContextProvider accepts to configure the dimensions of the NavigationBar:

    dimensions: {
        headerMobileHeight: number;
        headerDesktopHeight: number;
    };

But these dimensions are not being used by the NavigationBar component

There is a context named FixedToTop that allows to set the height of the elements that are being placed to the top (like a NavigationBar) but the NavigationBar component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:

https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51

Possible improvements

pladaria commented 5 months ago

comment from teams image