Closed marcoskolodny closed 3 weeks ago
Size stats
master | this branch | diff | |
Total JS | 12.2 MB | 12.2 MB | +1.1 kB |
JS without icons | 2.03 MB | 2.03 MB | +1.1 kB |
Lib overhead | 76.4 kB | 76.4 kB | 0 B |
Lib overhead (gzip) | 18.6 kB | 18.6 kB | 0 B |
Accessibility report ✔️ No issues found
ℹ️ You can run this locally by executing yarn audit-accessibility
.
Deploy preview for mistica-web ready!
✅ Preview https://mistica-7fw3egfmt-flows-projects-65bb050e.vercel.app
Built with commit 8c82f3f6ad50a6f005edb91e1243843cf0f7a502. This pull request is being automatically deployed with vercel-action
Screenshot tests report
✔️ All passing
remark note doesn't apply anymore, right?
remark note doesn't apply anymore, right?
@yceballost well, given that it's written in past tense, I don't see anything wrong about it. It's just a clarification that explains why there are visual changes in the small buttonLink too
:tada: This PR is included in version 15.21.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
BREAKING CHANGE: ButtonLink won't be small as default anymore
Issue: Link
:warning: Remark
The height of a small ButtonLink (only in desktop) was not equivalent to the one in any other small Button:
This was because according to design specs, the ButtonLink used
<Text3/>
in desktop, while other buttons use harcoded values for the text component. I've reviewed this with design and they agreed on updating the ButtonLink so it uses the same text sizes as the other buttons.This change causes small visual changes in the small version of ButtonLink too, and that is expected.