search

Telefonica / prometheus-kafka-adapter

Use Kafka as a remote storage database for Prometheus (remote write only)
Apache License 2.0
364 stars 135 forks source link

Documentation for configuring Kafka SSL connection is wrong #33

Closed obitech closed 4 years ago

obitech commented 4 years ago

The documentation states that the Kafka SSL connection can be configured via the following variables:

KAFKA_TLS_CLIENT_CERT_FILE: Kafka SSL client certificate file, defaults to ""
KAFKA_TLS_CLIENT_KEY_FILE: Kafka SSL client certificate key file, defaults to ""
KAFKA_TLS_CLIENT_KEY_PASS: Kafka SSL client certificate key password (optional), defaults to ""
KAFKA_TLS_CA_CERT_FILE: Kafka SSL broker CA certificate file, defaults to ""

However, the config expects _SSL_ instead of _TLS_ inside the variable names in https://github.com/Telefonica/prometheus-kafka-adapter/blob/master/config.go#L82:

    if value := os.Getenv("KAFKA_SSL_CLIENT_CERT_FILE"); value != "" {
        kafkaSslClientCertFile = value
    }