search

Telefonica / prometheus-kafka-adapter

Use Kafka as a remote storage database for Prometheus (remote write only)
Apache License 2.0
364 stars 135 forks source link

Bump Kafka dependencies #35

Closed obitech closed 4 years ago

obitech commented 4 years ago

Bump librdkafka from v1.0.1 to v.1.30 Bump confluent-kafka-go v1.0.0 to v1.3.0 Bump librdkafka and librdkafka-dev version to >1.3.0 At the moment librdkafka>=1.3.0 is only available from the community/edge repository.

Fixes #34

obitech commented 4 years ago

/cc @palmerabollo

palmerabollo commented 4 years ago

The ci failed with the following error, which is weird because you already bumped librdkafka to v1.3.0:

/go/pkg/mod/github.com/confluentinc/confluent-kafka-go@v1.3.0/kafka/00version.go:44:2: error: #error "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"

error "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"

obitech commented 4 years ago

@palmerabollo yup, I need to bump it in the Dockerfile as well. I'm working on it :)

obitech commented 4 years ago

@palmerabollo right now librdkafka v1.3.0 is only available on the alpine edge/community branch: https://pkgs.alpinelinux.org/packages?name=librdkafka&branch=edge

We need to watch out in future builds in case this changes:

[...] most Alpine package repos contain an "edge" branch, which may drop package versions that are not deemed fit to make it into a stable branch. This means that pinning to a version on the edge branch may stop working after the package version is revoked from the repo.

I assume we'll see it on the main branch soon.

palmerabollo commented 4 years ago

A new docker image (1.5.0) has just been published. Thanks again for improving this project.