Telefonica / puppet-github-actions-runner

In This Repository you can find a module that will setup all of the files and configuration needed for GitHub Actions runner to work on Linux hosts (Ubuntu, Debian and CentOS).

Apache License 2.0

12 stars 15 forks source link

fix: default org only token url #26

Closed pdemonaco closed 3 years ago

pdemonaco commented 3 years ago

Summary

The default path for the API to retrieve the runner token was calculated incorrectly including 'repos' instead of 'orgs' which causes the token retrieval to fail.

I'm guessing at some point github changed their API from https://api.github.com/**repos**/$org_name/ to https://api.github.com/**orgs**/$org_name/ which broke the behavior of the token_url when no repo is specified.

Fix Details

Changes the token_url calculation logic in the instance defined type to correctly use orgs when no github.com api string override is provided.
Adds some quick and dirty test code to make sure the creation script is built as expected.

mrodm commented 3 years ago

Closing this PR in favor of #32