Telegram-FOSS-Team / Telegram-FOSS

Unofficial, FOSS-friendly fork of the original Telegram client for Android
GNU General Public License v2.0
2.96k stars 378 forks source link

Telegram 3.18.0 source code! #131

Closed ghost closed 7 years ago

ghost commented 7 years ago

Looks like its updated :+1: :tada:

https://github.com/DrKLO/Telegram

Pavel Durov tweet: https://twitter.com/durov/status/847454485882355713

Telegram 3.18 blog: https://telegram.org/blog/calls

:tada:

vn971 commented 7 years ago

@user1831 completing the review probably? After all, this should be a FOSS version. (I'm not a maintainer.)

thermatk commented 7 years ago

@Bubu or @slp are managing this

If someone can review all the commits with [REVIEW] in #137 and #138 and tell us what's happening there, it will be beneficial too. If you find a vulnerability, don't forget to apply for the Telegram bounty program :rofl:

vn971 commented 7 years ago

@thermatk BTW, do all devices have armv7 already? I'm trying to install the last published version on my old devices, and it doesn't work somehow. It says "there was a problem parsing the package". I do have "install from unknown sources" enabled.

( EDIT: this device: https://en.wikipedia.org/wiki/Samsung_Galaxy_Note_8.0 )

thermatk commented 7 years ago

@vn971 armv6 I haven't seen for six years or so. The thing is, this is for sdk 23+(marshmallow 6.0), which you probably don't have unless you use a custom ROM I can compile all possible apks, but it would be better if this gets merged and f-droid compiles them signed with proper keys, etc.

thermatk commented 7 years ago

It looks like the Telegram source code includes a contagious disease that first made the original author hide for six months and now got our maintainers :rofl:

ghost commented 7 years ago

@Bubu @slp help needed!

slp commented 7 years ago

Hi all,

As I already hinted before, I'm no longer interested in maintaining this FOSS version of Telegram. These are my reasons:

  1. Lack of time.
  2. Upstream maintains its extremely hostile development model.
  3. I'm really concerned about Telegram's purpose as an organization.
  4. There are better alternatives, some fully FOSS and federated (like Matrix/Riot), some with PFS encryption (like Signal).
  5. As a consequence of 2, 3 and 4, I'm no longer using Telegram for my personal communication needs.

If someone (@thermatk ?) wants to take over the work, I'll give him/her full access to this repo. If someone wants the job but prefers to use his/her own repo, I'll sponsor the switch on FDroid.

Peque commented 7 years ago

@slp Thanks for all your hard work during this period. Wish you the best.

thermatk commented 7 years ago

I would rather do this as part of a team, maybe it's time to transfer the repo to a Github organization and call for more people? I don't know much about native code and with every release this part is growing And I think @Bubu is still around, he's just missing for a few days, so two people in the org already probably :+1: Who is in?

thermatk commented 7 years ago

@slp you can transfer the repo here then https://github.com/Telegram-FOSS-Team and we'll try to find a solution :)

ghost commented 7 years ago

@slp Thank you for everything!

@thermatk great idea!

thermatk commented 7 years ago

When the repo is transferred, I'll merge everything and push change to metadata on F-Droid. Shouldn't be hard

slp commented 7 years ago

@thermatk I've just transferred the repo.

thermatk commented 7 years ago

https://gitlab.com/fdroid/fdroiddata/merge_requests/2190

vn971 commented 7 years ago

The PR was merged, waiting for F-Droid servers to build it.

nicolasmaia commented 7 years ago

is this real life/

thermatk commented 7 years ago

While it's not built, if someone knows how to do myLocationOverlay properly on osmdroid, please do it :)

139

it works, but I want full feature parity and beauty... which is really close, but not there yet There you go with the latest debug apk:

TMessagesProj-fat-debug.apk.zip

ghost commented 7 years ago

@thermatk seems like something went wrong :(

org telegram messenger_-_f-droid_-_2017-04-19_16 24 51

https://f-droid.org/wiki/page/org.telegram.messenger

notpushkin commented 7 years ago

The build log is missing though? Strange.

ghost commented 7 years ago

@iamale @thermatk I made an Issue:

https://gitlab.com/fdroid/fdroiddata/issues/702

thermatk commented 7 years ago

The lastbuild page shows nothing after November, maybe it just means it has recognized the change in metadata and will try to build some time later? 🤔

thermatk commented 7 years ago

Yup, I checked with other apps. I think that it has never tried to build, everything should be ok, it's a step in the right direction 😉

thermatk commented 7 years ago

Now they have a problem with the build server, maybe next iteration is our big chance :+1: https://f-droid.org/wiki/page/org.telegram.messenger/lastbuild_9575

ghost commented 7 years ago

Thanks for the update @thermatk and for your hard work in this repo!

thermatk commented 7 years ago

Ok, now it really fails. Have no idea why yet :cry:

thermatk commented 7 years ago

I've tried it from scratch starting with git clone, no issues: https://pastebin.com/xXYvFvgL

ghost commented 7 years ago

@thermatk

I think they are telling us it has to do with their build server, but I'm not sure:

https://gitlab.com/fdroid/fdroiddata/issues/702

He says:

On the sample app in question: There is a compilation failur as well, will try to work on this tomorrow.

thermatk commented 7 years ago

I have a theory: I use ndk r14, build-server uses r12b https://gitlab.com/fdroid/fdroiddata/merge_requests/2199 We really need someone who understands all those native code games :+1:

vn971 commented 7 years ago

@thermatk can't this be the reason why I couldn't install telegram-beta on my old devices (Samsung Galaxy S3, Samsung Galaxy Note 8.0) ? IDK actually, just guessing. Have to test more.

ghost commented 7 years ago

@thermatk

I think your merge request is working!

https://gitlab.com/fdroid/fdroiddata/commit/4810c4163bc252305fd92eeadeaee21e5f65f6e8

Boris Kraut @krt commented about 2 hours ago

Yep, builds for me, thanks.

kitsunyan commented 7 years ago

@vn971 do you have installed APK on these devices? The certificates won't match in this case.

If you sure in this, try to install using adb (adb install -r TMessagesProj-fat-debug.apk), it will show you error mesage. You also can try to use logcat. There should be messages tagged PackageManager or PackageInstall with error explanation.

thermatk commented 7 years ago

@user1831 the build server of F-Droid did not run since the 23rd, same delays happened after initial merge: they have some known issues with it. But most of the time was spent because there was no one managing the project, so even when I did and redid the pull requests merging everything in three different variations with @Bubu coming and rethinking the structure and approach, nothing actually happened :rofl: And then @Bubu vanished as well in the process I am open to PRs, so next time don't forget to contribute even if I'm busy with something :+1:

thermatk commented 7 years ago

It's over! :raised_hands: https://f-droid.org/wiki/page/org.telegram.messenger/lastbuild_9575

ghost commented 7 years ago

Awesome! Party time :)

On 2017-04-25 15:54, Ruslan Boitsov wrote:

It's over! 🙌 https://f-droid.org/wiki/page/org.telegram.messenger/lastbuild_9575

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Telegram-FOSS-Team/Telegram-FOSS/issues/131#issuecomment-297037496, or mute the thread https://github.com/notifications/unsubscribe-auth/AMhqQzczRuhZ0mBwFRzsikgPdD8Cbzwbks5rzfscgaJpZM4MvJsk.

ghost commented 7 years ago

It's Christmas :smiley:

jooola commented 7 years ago

Hopefully, anyone will develop a good messenger at any time and there will be no need for a FOSS version because the original version matches this feature. Maybe I'm still alive when it happens.

Maybe if you give Wire a try ! Still in beta but already great !

Great job guys ! Thanks

vn971 commented 7 years ago

@jooola as much as we want, I think we should refrain from discussing offtopics in this ticket.

danialbehzadi commented 7 years ago

Hopefully, anyone will develop a good messenger at any time and there will be no need for a FOSS version because the original version matches this feature. Maybe I'm still alive when it happens.

What about GNU Ring? it is completely GPLv3 free software, p2p with e2e encryption.

thermatk commented 7 years ago

@user1831 someday the developer of upstream app will change, because I have a feeling it's his personal opinion about open source, github, etc., that is affecting the source code releases. The desktop client repo is very much alive. All the updated apps are to be signed and uploaded at once sometime this week,

@jooola just FYI, Wire, apart from having ~0 users, is not on F-Droid and you can't even be sure it will ever be, issue https://github.com/wireapp/wire-android/issues/5 is there since summer. In my opinion, Telegram is still, to my own surprise, the only IM with a fully functional FOSS client and a lot of users at the same time. Luckily, in the world of end-to-end encryption the FOSS client is the required minimum to feel safe. Signal only works as a gms-dependent apk signed by moxie, an attempt to make a compatible FOSS fork(just like ours!) talking to the same server resulted in moxie "being not OK". For some months, Signal supports installation on devices without gms, but drains battery. Riot has no users and functionality is different, I think. The future looks bright, as always.

I'll continue to support Telegram then, even if it means getting bleeding-edge functionality a month later :D

This has become a broad discussion topic a long time ago, I've even invented the blue label for it :rofl:

jooola commented 7 years ago

@jooola just FYI, Wire, apart from having ~0 users, is not on F-Droid and you can't even be sure it will ever be, issue wireapp/wire-android#5 is there since summer.

Current ticket is wireapp/wire-android/issues/233. But yeah, i still don't really use/know Wire and I didn't found better but @user1831 juste did ! Ring looks promising (gonna try it) ! Still Wire is slowly on his way to the FOSS light. (only bad thing could be "Many employees working on Wire have previously worked with Skype, and Skype's co-founder Janus Friis is backing the project." Wikipédia) EDIT: See link in next comment about Wire

In my opinion, Telegram is still, to my own surprise, the only IM with a fully functional FOSS client and a lot of users at the same time.

👍 I will keep Telegram for a while I think.

ghost commented 7 years ago

For me personally, every messenger has its issues. So far telegram has been stable, e2e (secret chats), easy to use, and like @thermatk said, one day upstream might see improvement.

I tried Antox, Wire, Conversations, Ring, Riot and yet, I keep coming back to Telegram. It's not perfect, but its what works for me.

This is just my experience, I'm personally happy this build is now working. Thanks again for all the hard work!

ghost commented 7 years ago

What about Matrix? Doesn't that work yet?

notpushkin commented 7 years ago

@Matttter Riot is a Matrix client. It does work, but is a bit unstable right now (also, it looks like Slack, which is probably why @mastad0n thinks it is made for team chats (which is probably right)). Maybe a separate, more Telegram-ish Matrix client could be made, although this is a duplication of efforts IMO.

notpushkin commented 7 years ago

Has anybody tried Actor though? It builds up on Telegram's legacy and looks almost identical, but has open-source server in addition to the clients. It isn't a federation, though, if I'm not mistaken (so it's impractical to run your own server if you don't want to set up a secret team or something like that).

jooola commented 7 years ago

Has anybody tried Actor though? It builds up on Telegram's legacy and looks almost identical, but has open-source server in addition to the clients. It isn't a federation, though, if I'm not mistaken (so it's impractical to run your own server if you don't want to set up a secret team or something like that).

Looks like a great app too ! But app isn't aviable on fdroid and currently the website is down. I installed it and I couldn't register ( maybe because I don't have the Google Service Framework (GSF) installed). Sad...

notpushkin commented 7 years ago

Oh, the site is down for me as well. I last checked it about half a year ago and it was still working. They might have abandoned the project after all. :(

And another thing that came to my mind:

thermatk commented 7 years ago

I'm not sure what you all guys want... %) @iamale There is nothing wrong with the app we have here, no reason to port a less functional non-native(for Android) Qt app. 3.18 is here, with full feature parity because I've kind of ported location sharing to osmdroid, although it's not 100% done yet =D Calm down, update f-droid repos in the next 1-5 days(last signing session happened on the 23rd, so another one should be close) and think how you can contribute to this very project :1st_place_medal:

notpushkin commented 7 years ago

@thermatk I'm not suggesting it would be useful right now, of course, just a backup plan :)

ghost commented 7 years ago

What I meant was, doesn't Matrix "federate" with Telegram? Did anyone get that to work reliably? Because everyone is locked to the platform they're already in (my case, mostly Telegram after I just flat out refused to further communicate with Whatsapp, and that almost split my family in half), and if "federated" like that I can just switch and get people to switch gradually... I just can't figure out how to make it run on my rpi3? Maybe I'm just stupid

av2k commented 7 years ago

A big "Thank you!" to all contributors! The Telegram Android client is of very high quality, waiting a few days or weeks to get it in FOSS flavor is absolutely worth it. I would even go as far to say that Telegram is currently the best mobile messenger available in terms of security, source-openness, functionality and code stability.