search

Telegram-FOSS-Team / Telegram-FOSS

Unofficial, FOSS-friendly fork of the original Telegram client for Android
GNU General Public License v2.0
2.92k stars 374 forks source link

Free-hand drawed messages #188

Open gDanix opened 6 years ago

gDanix commented 6 years ago

I propose to make an easy way to create free-hand draws and to send them as images. It would be something very close to the image editing tool already present in Telegram, but working on a blank canvas instead a preexisting image, and easier to access (maybe a third item in the voice/video messge selector).

I was thinking on implementing this by myself and then make a PR on the original @DrKLO repository, but I'm afraid I'll be wasting my time, so I was wondering: ¿Can I implement this feature in Telegram-FOSS?

Thank you.

omkarnathsingh commented 6 years ago

This sounds good to me.

thermatk commented 6 years ago

If it's a kind of oneliner with a static white or transparent image instead of a photo, that would be ok But it would be impossible to maintain a multifile patch with many lines all over the place, unless you are ready to do that

gDanix commented 6 years ago

Yes, that's what I was thinking.

Would it help to code everything in files apart from the core to be imported after every official app code release? Maybe this way a lot of features can be implemented without having merge conflicts.

Calling this "plugin" system by a oneliner from the upstream can be easy to maintain and can improve this client a step ahead from the official one. But don't know if Android has reflection capabilities needed to do this without changing so much upstream lines...