search

Telegram-FOSS-Team / Telegram-FOSS

Unofficial, FOSS-friendly fork of the original Telegram client for Android
GNU General Public License v2.0
2.87k stars 370 forks source link

Allow secure backup #653

Open jcz1 opened 1 year ago

jcz1 commented 1 year ago

Hello.

I use SeedVault (integrated in LineageOS, GrapheneOS etc.) for secure (encrypted) backup apps and data to my device (USB) or my server (NextCloud).

But Telegram-FOSS is opted-out from backups so it is not possible to save data by SeedVault :( Please can you allow encrypted backups? There is more info:

https://github.com/seedvault-app/seedvault/wiki/FAQ

And an example of commit:

https://github.com/grote/Transportr/commit/4dc38f429f75909a088d8bd8a5b3b5ddd8030f71

Thanks.

theoware commented 1 year ago

What would you backup, Telegram only works properly online?

jcz1 commented 1 year ago

App config / settings, media cache, account.

ildar commented 1 year ago

Account is truely easily and securely restored through SMS. Media cache is ... (hmm... you really want to backup it?) easily accessible, it is in your /sdcard/ . You CAN backup it separately.

nazar-pc commented 1 year ago

Major pain for me to move to non-rooted device too. I'd like to back up literally everything, wipe the old phone, start new phone, restore from backup and know that every file and every setting remained where it was rather than setting things up from scratch for every single.app.

So unless there is a valid reason to disable client-side encrypted backups they should be enabled and is trivial to do.

Of course I can copy a bunch of things manually and with root access (which is not always the case) I can do even more than that, but it is 2023 and we have automation for things, the only requirement from Telegram-FOSS here is to not disable it.

ildar commented 1 year ago

Does adb backup save the settings?

mgw2013 commented 1 year ago

@ildar ...it depends...

nazar-pc commented 1 year ago

The reason is this line in the app: https://github.com/Telegram-FOSS-Team/Telegram-FOSS/blob/e68d4eb83a7952de62cf65eaa0cead64de478dcc/TMessagesProj/src/main/AndroidManifest.xml#L87

mgw2013 commented 1 year ago

The question is, should we deviate from T default settings? Not allowing backups is a common misbehavior among most app's. I can't envision a reason why we should not allow Android backups?

Younes-L commented 1 year ago

see the latest upstream changes https://github.com/DrKLO/Telegram/blob/master/TMessagesProj/src/main/AndroidManifest.xml#L87

nazar-pc commented 1 year ago

Time to upgrade to 9.4.0 then :slightly_smiling_face:

drizzt commented 9 months ago

This is already fixed and should be closed