search

Telegram-Mini-Apps / TelegramUI

React components library for Telegram Mini Apps inspired by Telegram interface
https://ton.org/mini-apps
MIT License
448 stars 35 forks source link

React 18.3.1 couldn't resolve as dependency #39

Closed MiXeR54 closed 5 months ago

MiXeR54 commented 5 months ago

Can we bump React dependant version?

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: reactjs-template@0.0.1
npm error Found: react@18.3.1
npm error node_modules/react
npm error   react@"18.3.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"18.2.0" from @telegram-apps/telegram-ui@2.1.4
npm error node_modules/@telegram-apps/telegram-ui
npm error   @telegram-apps/telegram-ui@"2.1.4" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
MiXeR54 commented 5 months ago

I've made changes for this issue, also update all deps in repo.

Please review.

https://github.com/Telegram-Mini-Apps/TelegramUI/pull/40

mainsmirnov commented 5 months ago

Thank you, fixed in version 2.1.5