Telegram-Mini-Apps / telegram-apps

Made from scratch TypeScript packages, examples and documentation you will surely need to start developing on Telegram Mini Apps.
https://docs.telegram-mini-apps.com/
MIT License
691 stars 191 forks source link

feat(sdk-svelte): added sdk for svelte.js #522

Closed ugrinovsky closed 3 weeks ago

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 5c60dc4b11c883447b114e71f15c1206f0e6e989

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:15pm
heyqbnk commented 3 weeks ago

Hey Nazar! Great job on this PR!

I would ask you to do a bit more to merge this Pull Request into the master branch:

  1. Write the package documentation. You can use docs for Vue SDK as a reference
  2. Create a "playground" in the playgrounds folder, so we could try the SDK in real-time. You can also use Vue, Solid and React playgrounds as a reference. The playground should be just a dead-simple application using the SDK, nothing complex. You can use any Svelte scaffolders (I don't really know what exactly is used to rapidly start the a Svelte app) for it.

The documentation is placed in the docs folder. To run it, just use the pnpm run docs:dev command in the repository root directory.

About playground: just create a separate folder in the playgrounds folder and implement the application there, using the @telegram-apps/sdk-svelte package as the dependency ("@telegram-apps/sdk-svelte": "workspace:*").

heyqbnk commented 3 weeks ago

Thank you for a great job! Merged