TelegramBots / Telegram.Bot

.NET Client for Telegram Bot API
https://telegrambots.github.io/book
MIT License
3.17k stars 686 forks source link

New Line problem in PhotoMessages #409

Closed emran17 closed 7 years ago

emran17 commented 7 years ago

I think , It's a problem in new update . "\n" or Environment.NewLine dont affect the caption of photo messages. It shows \n in the caption.

I dont changed my codes ! but after update ! this problem happend . NuGet Package Version: (13.1.0)

poulad commented 7 years ago

@emran17 Thanks for the report. Here is the fix: https://github.com/TelegramBots/telegram.bot/commit/cc8da5ff9c3daa001fd54a265534128c30143417

poulad commented 7 years ago

@Olfi01 Regarding this issue, could you reapond my commemts on your commit here: https://github.com/TelegramBots/telegram.bot/commit/b1924b92e543f9b51642706dfe96a05edef0ec98

Olfi01 commented 7 years ago

i guess this will work, but you should try uploading anything via multipart in a channel to see if the error reocurrs shouldn't though

poulad commented 7 years ago

@Olfi01 Got it. I'll test that.

poulad commented 7 years ago

@Olfi01 I tested my fix https://github.com/TelegramBots/telegram.bot/commit/cc8da5ff9c3daa001fd54a265534128c30143417 with posting messages to a public channel. It works fine.

Olfi01 commented 7 years ago

Well done then, its fixed ;)

emran17 commented 7 years ago

I dont use github ! I installed it , from nuget ! when you will update nuget for fixing bugs ?

poulad commented 7 years ago

@emran17 Fixes are ready to be merged. Just waiting for @MrRoundRobin to reply.

poulad commented 7 years ago

@emran17 I have updated this package for the time being: https://nuget.org/packages/Telegram.Bot.Core/

Get version 13.2.0.

poulad commented 7 years ago

If any one wonders why I put this fix in another package (.Core), have a look at #425