search

TelegramBots / Telegram.Bot

.NET Client for Telegram Bot API
https://telegrambots.github.io/book
MIT License
3.17k stars 686 forks source link

Expose BaseUrl and BaseFileUrl settings #829

Closed MihaZupan closed 4 years ago

MihaZupan commented 5 years ago

Did we reach a conclusion as to whether to implement this by just making the properties public, or by adding ctor parameters?

tuscen commented 5 years ago

I'm fine with making them instance properties with public setters. Though there's one caveat I'm thinking about. Consider a situation: the client is used to poll for updates and the URLs are changed during polling. In that case maybe ctor parameters would be better.

MihaZupan commented 4 years ago

I've changed my mind - we shouldn't expose this as an API.

For anyone requiring such functionality, there is a workaround, see https://github.com/TelegramBots/Telegram.Bot/pull/857#issuecomment-657108726