TelegramMessenger / Telegram-iOS

Telegram-iOS
5.4k stars 1.45k forks source link

fix assets names "ThumbsUp" <-> "ThumbsDown" #1374

Closed voronoff2803 closed 1 month ago

voronoff2803 commented 2 months ago

The names of the thumbs up and thumbs down icons were mixed up in places. In the voice recognition UI. This had the effect of making user feedback degrade recognition algorithm 🤯

Снимок экрана 2024-03-24 в 23 27 32
voronoff2803 commented 2 months ago
self.upButtonImageNode = ASImageNode()
self.upButtonImageNode.image = generateTintedImage(image: UIImage(bundleImageName: "Chat/Context Menu/ThumbsUp"), color: presentationData.theme.contextMenu.primaryColor, backgroundColor: nil)
self.upButtonImageNode.isUserInteractionEnabled = false

self.downButtonImageNode = ASImageNode()
self.downButtonImageNode.image = generateTintedImage(image: UIImage(bundleImageName: "Chat/Context Menu/ThumbsDown"), color: presentationData.theme.contextMenu.primaryColor, backgroundColor: nil)
self.downButtonImageNode.isUserInteractionEnabled = false

...

self.upButtonNode.addTarget(self, action: #selector(self.upPressed), forControlEvents: .touchUpInside)
self.downButtonNode.addTarget(self, action: #selector(self.downPressed), forControlEvents: .touchUpInside)

The correct names are used in the code. Only the pictures in the assets are incorrect

voronoff2803 commented 2 months ago

IMG_5082

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.