search

TelegramMessenger / Telegram-iOS

Telegram-iOS
6.34k stars 1.66k forks source link

"No archived" folder filter is handled inconsistent with tdesktop app when a chat is both included and excluded #335

Open yeputons opened 4 years ago

yeputons commented 4 years ago

Checklist

Description

Behavior between iOS and tdesktop clients regarding chat filtering in folders is inconsistent (telegramdesktop/tdesktop#8427) and tdesktop devs say that their behavior is correct.

Steps to Reproduce

  1. Choose an arbitrary chat X.
  2. Archive the chat X.
  3. Create a folder which "includes" the chat X (as an individual chat, not by chat type), but "excludes" all archived chats.
  4. Check whether the folder shows the chat X in tdesktop.
  5. Check whether the folder shows the chat X in mobile app (I've used iOS).

Expected Behavior

Behavior should be consistent between tdesktop and iOS app: either chat X is consistently shown both in tdesktop and mobile app, or the folder is consistently empty.

Actual Behavior

Behavior is inconsistent: tdesktop 2.3 shows the chat X (i.e. its exclusion by "archived" does not work), but iOS app 7.0 does not (i.e. it excludes all archived chats, even if they're explicitly listed in the "archived" section).

Environment

Device: iPhone

iOS version: 13.3.1

App version: 7.0

kodawah commented 1 year ago

FWIW I think the iOS implementation makes the most sense, the Archived tag conveys the meaning that chats should be archived - ie not in the same place as non-archived chat, therefore the exclusion rule should apply before the inclusive one, IMO