search

TelegramMessenger / telemint

Telegram Auction Platform smart contracts
GNU General Public License v3.0
345 stars 71 forks source link

Fix ownership bug #18

Closed Tindarid closed 2 years ago

Tindarid commented 2 years ago

If the auction ends on the line 181 in the original code and we received, for example, op::get_royalty_params - we will not update owner address (but we need to update it to the bidder address, because we have sent op::ownership_is_assigned to the bidder).

Note: it can be done better and faster, proposed solution is addressing the issue without introducing new potentially buggy code.

starlightduck commented 2 years ago

This will add overhead of pack_item_state and save_item_data to every message while auction is running - including internal gets and bids. The overhead of those operations may be noticeable since they pack and store data to blockchain.

Tindarid commented 2 years ago

Thank you for your explanation, please pay attention to the description of PR

arseny30 commented 2 years ago

We will merge this change now and add some optimizations later.