search

TelegramMessenger / telemint

Telegram Auction Platform smart contracts
GNU General Public License v3.0
337 stars 69 forks source link

Add TLb description for generated messages? #43

Open bminaiev opened 1 year ago

bminaiev commented 1 year ago

Maybe also add a TLb description of all messages, which contracts could generate and send to external contracts?

For example, at the end of the auction, nft-item sends an ownership_assigned message to a new owner, but it is not clear what is the format of the message. E.g. what does .store_int(0, 1) mean in that query? And why bidder_address is stored in that message (they probably already know their address)? Should it be prev_owner instead (similar to nft_answer_ownership_assigned)?

arseny30 commented 1 year ago

ownership_assigned is from TEP 62 But yes, it makes sense to include its description in the schema.

bminaiev commented 1 year ago

Hmm, if it is ownership_assigned from TEP 62, then it is a bug, that bidder_address is stored there, not owner? Am I missing something?

bminaiev commented 1 year ago

Made a PR in case this is indeed a bug: https://github.com/TelegramMessenger/telemint/pull/62