search

TelemetryDeck / SwiftSDK

Swift SDK for TelemetryDeck, a privacy-conscious analytics service for apps and websites.
https://telemetrydeck.com/
Other
149 stars 30 forks source link

Remove `waitsForConnectivity` #114

Closed finnvoor closed 10 months ago

finnvoor commented 10 months ago

As mentioned in https://github.com/TelemetryDeck/SwiftClient/issues/52, setting waitsForConnectivity causes all events that occur when there is no network connection to be lost when an app is quit.

I don't really see any need to check for network connection before calling send, with this change the dataTask will instantly fail and return an error (adding the signals back to the queue) since URLSession is checking the NWPath anyway.

winsmith commented 10 months ago

Fantastic! Thanks for this contribution!