search

TelemetryDeck / SwiftSDK

Swift SDK for TelemetryDeck, a privacy-conscious analytics service for apps and websites.
https://telemetrydeck.com/
Other
148 stars 30 forks source link

Access to DefaultSignalPayload #115

Closed nevillco closed 8 months ago

nevillco commented 10 months ago

I am trying out a project that uses TelemetryDeck analytics on iOS via this SDK and on the backend via Vapor. It's working well and the combination of frontend/backend events allows for some clear insights/funnel analysis.

This SDK sends a number of default properties including appVersion, buildNumber, isTestFlight, isAppStore etc. via the DefaultSignalPayload. Several of these signals would be useful to pass to my backend events, but that's not currently possible because the associated values are internal. I would like to expose them to clients, but thought I'd start with an issue before a PR just because I'm not sure if it's something the maintainers want. Happy to raise a PR if it is.

winsmith commented 8 months ago

Oh yes please create a PR! Thank you :)

BTW you might also consider checking out the dedicated Vapor SDK: https://github.com/getsidetrack/vapor-telemetrydeck

nevillco commented 8 months ago

Yep, I am using that on the backend, and it works great! I'd just like to have its events also contain a appVersion, buildVersion, isAppStore etc. like the client events do, hence this feature request. PR here.

winsmith commented 8 months ago

Fixed by https://github.com/TelemetryDeck/SwiftClient/pull/126