TelemetryDeck / SwiftSDK

Swift SDK for TelemetryDeck, a privacy-conscious analytics service for apps and websites.
https://telemetrydeck.com/
Other
149 stars 30 forks source link

send extension identifier, if provided #93

Closed Sherlouk closed 1 year ago

Sherlouk commented 1 year ago

iOS and other Apple operating systems have a plethora of extension types all with a unique identifier which can be retrieved from the Info.plist for the current target.

A complete list of identifiers can be found here: https://developer.apple.com/documentation/bundleresources/information_property_list/nsextension/nsextensionpointidentifier

It is useful for developers to understand the source of the events, including whether it came from a widget, notification service, or other extension.

Closes #29

⚠️ - this will upload raw identifiers which may not be immediately understandable by developers. It would be nice to enrich or prettyify this data by rendering the likes of "com.apple.widgetkit-extension" as "Widget Extension" or "com.apple.usernotifications.content-extension" as "Notification Content Extension". This would ideally be done on the backend in order to quickly support new identifiers added in the future, and in order to keep the SDK as light as possible. It's important we accept this piece of server-side work before merging this, else we need to add that same information into the SDK.

winsmith commented 1 year ago

Fantastic!

Regarding your warning: I agree that prettifying this should happen on the frontend or the server somehow. I don't want to prevent customers from accessing the raw data, but we already have various autogenerated charts and it fits in with those.