search

TelepathicGrunt / Blame

make crashlogs more detailed for certain crashes
GNU Lesser General Public License v3.0
11 stars 1 forks source link

Possible false positive #45

Closed cheshyrp closed 3 years ago

cheshyrp commented 3 years ago

Blame reports several unregistered features in the Apotheosis mod. However, the mod's author insists that everything is registered and provided the source code. Here's a link to my bug report and the author's response.

https://github.com/Shadows-of-Fire/Apotheosis/issues/431

TelepathicGrunt commented 3 years ago

The funny thing is, every time someone said the configuredfeature was registered and Blame was wrong, it always turns out that Blame is right lmao. I'll take a look and see what he needs to fix

TelepathicGrunt commented 3 years ago

Yep. They registered their stuff incorrectly. I left details on their issue report so I'll close this one here. Hopefully they will reopen and fix their registration. Thank you for reaching out to me so I could help out!

cheshyrp commented 3 years ago

That was my thought as well. Especially since these so-called features are actually structures.

On Aug 9, 2021, at 5:37 PM, TelepathicGrunt @.***> wrote:

 The funny thing is, every time someone said the configuredfeature was registered and Blame was wrong, it always turns out that Blame is right lmao. I'll take a look and see what he needs to fix

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

cheshyrp commented 3 years ago

My pleasure. Thank you for the help.

TelepathicGrunt commented 3 years ago

It's not that. Configuredfeature cannot be registered as Configuredstructures. That's an entirely different thing and the registry wouldn't even take them. The issue was that he was using the wrong name for registering which made all of his configuredfeatures in the configuredfetaure registry have the same name. Which means that all but one were kicked out of that registry due to having the same name which leads to unregistered configuredfeatures that Blame found. It is confusing