search

TelepathicGrunt / Bumblezone

A bee dimension just for fun!
https://www.curseforge.com/minecraft/mc-mods/the-bumblezone-forge
GNU Lesser General Public License v3.0
181 stars 37 forks source link

bee drops two stingers 1.20.1 #327

Closed Aceplante closed 8 months ago

Aceplante commented 9 months ago

title, I feel like it should only drop one at a time, and not 100% of the time

TelepathicGrunt commented 9 months ago

What modloader and Bumblezone version? What other mods did you have on or what modpack are you playing on? Is this a vanilla bee or not? Did the bee have a stinger on or not? (It’s supposed to be a 100% drop rate if bee has stinger and 0% if no stinger)

Aceplante commented 9 months ago

Yes it was a vanilla bee. It did not sting me so it wouldve had a stinger, I was not using looting and dont think I had any other loot boosting effects,

Yea I checked the loot table and that does seem to be the case, so this may just be me

TelepathicGrunt commented 9 months ago

I still want your modpack if you are using latest bumblezone version and still experience the issue. A mod could be rolling a second separate loot table for bee death instead of adding their stuff to the bee loot table. My code could then be triggered twice as a result of the other mod rolling the entirely separate loot table

Aceplante commented 9 months ago

Sure, Ill test it on a minimal instance, just a sec

Aceplante commented 9 months ago

Ah, yep. It does not happen on a minimal instance, so Ill have to do more testing. You can close for now if you want, ill reopen if i find it

TelepathicGrunt commented 9 months ago

I like to keep issue reports open and marked with the problematic mod so others can come here and see the cause. It'll also help me as I can see if I can do anything to avoid the other mod's loot table or contact the other modder.

TelepathicGrunt commented 8 months ago

checking in, any luck? or link to the modpack you're using?

TelepathicGrunt commented 8 months ago

closing as no new info on what mod could be cause

Aceplante commented 8 months ago

Good news: https://github.com/Daripher/Auto-Leveling/issues/29

TelepathicGrunt commented 8 months ago

Reopening

https://github.com/Daripher/Auto-Leveling/blob/1a82e000dd4f82dfbedfe372d1ca5afeaac44ba2/src/main/java/daripher/autoleveling/event/MobsLevelingEvents.java#L107

Idea: mark the bee as drops done somehow so future rolls of loot table doesn’t drop item? Worry it could get accidentally triggered by drop scanning mods

TelepathicGrunt commented 8 months ago

Should be fixed now. What I do is I attach a temporary data to the entity when I rolled my loot table. Then check if entity was already marked before trying to roll it again and don't if so. This will stop any mod that is erroneously spawning mod loot table drops outside of Global loot Modifier system from causing me to do duplicate drops as well.