TelepathicGrunt / Bumblezone

A bee dimension just for fun!
https://www.curseforge.com/minecraft/mc-mods/the-bumblezone-forge
GNU Lesser General Public License v3.0
179 stars 35 forks source link

Bumblezone is broken with the future translucent sorting of Sodium #361

Closed Lolothepro closed 4 months ago

Lolothepro commented 4 months ago

This causes issues like this:

2024-02-25_19 40 07

IMS said: the problem is Bumblezone is giving an value of up which is aligned, but just completely wrong it gives up even on the sides even on the bottom

douira commented 4 months ago

The normal being given through the fluid handler api doesn't correspond to the facing (up/down/n/w/e/s). This breaks translucency sorting. I expect it to also be fixed on our end by simply distrusting the normals being passed in and recalculating them based on the actual geometry, but it's worth mentioning that the given normal is wrong.

TelepathicGrunt commented 4 months ago

I was copying vanilla’s bottom rendering and changing the height iirc. So I don’t know specifically which line is controlling the normals or how to fix it. It would also mean sodium isn’t supporting vanilla and many mods would be copying the same vanilla code.

Edited to word what I wanted to say better

douira commented 4 months ago

Sodium is going to be working around improper usage of the API by recalculating normals for all quads given through this API. Fabric's default implementation of the API doesn't enforce it (by, for example, breaking) and is less strict than the (albeit also compliant) implementation by Sodium.