TelepathicGrunt / RepurposedStructures-Quilt

Adds more variations of vanilla structures and features!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures-fabric
GNU Lesser General Public License v3.0
80 stars 11 forks source link

Crash on 1.16.3 #34

Closed Zano1999 closed 4 years ago

Zano1999 commented 4 years ago

It crash on fabric 1.16.3

[22:07:26] [main/INFO]: Loading for game Minecraft 1.16.3 [22:07:27] [main/WARN]: Warnings were found!

TelepathicGrunt commented 4 years ago

Seems to be saying it is crashing here:

https://github.com/TelepathicGrunt/RepurposedStructures-Fabric/blob/902c3e40ab0f9c4e3205f28a933af30ad8cf7dd6/src/main/java/com/telepathicgrunt/repurposedstructures/misc/VillagerTrades.java#L17-L18

I just tested with repurposed_structures-1.16.3-1.6.1 and fabric-api-0.22.1+build.409-1.16. And it seems it works just fine and the Cartographer gets the Jungle Fortress Map properly. image

My guess is that another mod cleared out cartographers's trading stuff by setting it to null instead of making it an empty array and that crashed my mod. Now you got a lot of mods on so it'll be hard to track down the conflicting mod. But if you can get me an export of all your mods, I can put them all on myself and start tracking down the problematic mod.

Zano1999 commented 4 years ago

I solved the problem, it was a mod with a wrong configuration that somehow crashed your mod, thanks anyway for the availability

TelepathicGrunt commented 4 years ago

Oh wow that was quick! Glad you were able to figure it out! Also, can you tell me which mod it was? Just so I can tell anyone else who gets the same issue to reset the mod's configs. :)

Zano1999 commented 4 years ago

https://www.curseforge.com/minecraft/mc-mods/better-wandering-traders