TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
156 stars 23 forks source link

Mods to make datapack for compat with #113

Open TelepathicGrunt opened 3 years ago

TelepathicGrunt commented 3 years ago

Mods that add new pieces to vanilla structures or redoes vanilla structures will need a compat datapack to work with Repurposed Structures's stuff. All mod compat datapacks will be listed here: https://www.curseforge.com/minecraft/texture-packs/search?search=repurposed+structures

Note: Just because a mod is listed here and not crossed out doesn't mean I will do it. It takes a lot of work to make the compat datapacks, test to verify it is working, and then maintain it. I will get to new mods when I have time and energy.


- Rats https://www.curseforge.com/minecraft/mc-mods/rats https://legacy.curseforge.com/minecraft/data-packs/repurposed-structures-rats-compat

- Immersive Engineering https://www.curseforge.com/minecraft/mc-mods/immersive-engineering https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-immersive-engineering

- Incubation (adds a coop to villages) https://www.curseforge.com/minecraft/mc-mods/incubation https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-incubation-compat-datapack

- Simply Cats https://www.curseforge.com/minecraft/mc-mods/simply-cats https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-simply-cats-datapack-compat

- Sawmill https://www.curseforge.com/minecraft/mc-mods/sawmill https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-sawmill-compat

- Iron's Spells 'n Spellbooks https://www.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-irons-spells-n-spellbooks

- Etched https://www.curseforge.com/minecraft/mc-mods/etched https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-etched-datapack-compat

- Ice and Fire: Dragons https://legacy.curseforge.com/minecraft/mc-mods/ice-and-fire-dragons https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-ice-and-fire-datapack-compat

- Biome Makeover https://www.curseforge.com/minecraft/mc-mods/biome-makeover-forge https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-biome-makeover-compat

- Floralis https://www.curseforge.com/minecraft/mc-mods/floralis https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-floralis-compat

- More Villagers https://www.curseforge.com/minecraft/mc-mods/more-villagers https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-more-villagers-datapack

- Yung's Better Jungle Temples https://www.curseforge.com/minecraft/mc-mods/yungs-better-jungle-temples https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-better-jungle-temples-compat

- All bark, All bite (Pillager Outpost) https://www.curseforge.com/minecraft/mc-mods/all-bark-all-bite https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-all-bark-all-bite-compat

- Monobank https://www.curseforge.com/minecraft/mc-mods/monobank https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-monobank-compat

- Wares https://legacy.curseforge.com/minecraft/mc-mods/wares https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-wares-compat

- Paladins & Priests (RPG Series) https://www.curseforge.com/minecraft/mc-mods/paladins-and-priests https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-paladins-preists-compat

- Gazebos (RPG Series) https://www.curseforge.com/minecraft/mc-mods/gazebos https://legacy.curseforge.com/minecraft/texture-packs/repurposed-structures-gazebo-compat

- Jellyfishing https://www.curseforge.com/minecraft/mc-mods/jellyfishing https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-jellyfishing-datapack-compat

- Apocalyptic Fortress https://www.curseforge.com/minecraft/mc-mods/apocalyptic-fortress https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-apocalyptic-fortress-compat

- YUNG's Better Nether Fortresses https://www.curseforge.com/minecraft/mc-mods/yungs-better-nether-fortresses https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-yungs-better-nether-fortress

- Bygone Nether Fortress https://www.curseforge.com/minecraft/mc-mods/bygone-nether https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-bygone-nether-compat

- Villagers Plus https://www.curseforge.com/minecraft/mc-mods/villagersplus-fabric https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-villagerplus-compat-datapack

- Chef delight https://www.curseforge.com/minecraft/mc-mods/chefs-delight-fabric https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-chefs-delight-compat

- Wizards https://www.curseforge.com/minecraft/mc-mods/wizards https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-wizards-compat-datapack

- Domestic Innovation https://www.curseforge.com/minecraft/mc-mods/domestication-innovation https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-domestication-innovation

- Signpost (Signpost dev added compat with RS on their end in a awesome way!) https://www.curseforge.com/minecraft/mc-mods/signpost

- Bountiful https://www.curseforge.com/minecraft/mc-mods/bountiful https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-bountiful-datapack-compat

- Yung’s Better Desert Temples https://www.curseforge.com/minecraft/mc-mods/yungs-better-desert-temples https://www.curseforge.com/minecraft/mc-mods/yungs-better-desert-temples-fabric -https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-desert-temples-compat

- Yung’s Better Witch Huts https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-witch-huts-compat https://www.curseforge.com/minecraft/mc-mods/yungs-better-witch-huts

- Advanced Peripherals https://www.curseforge.com/minecraft/mc-mods/advanced-peripherals https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-advanced-peripherals-compat

- Drunken Mug https://www.curseforge.com/minecraft/mc-mods/drunken-mug https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-drunken-mug-compat-datapack

- Friends And Foes https://www.curseforge.com/minecraft/mc-mods/friends-and-foes https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-friends-and-foes-datapack

- PneumaticCraft: Repressurized https://www.curseforge.com/minecraft/mc-mods/pneumaticcraft-repressurized https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-pneumaticcraft-repressurized

- Hexerei https://www.curseforge.com/minecraft/mc-mods/hexerei https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-hexerei-datapack-compat

- Tidbits https://www.curseforge.com/minecraft/mc-mods/tidbits https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-tidbits-datapack-compat

- Tardis Mod https://www.curseforge.com/minecraft/mc-mods/new-tardis-mod https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-new-tardis-mod-datapack

- Etched https://www.curseforge.com/minecraft/mc-mods/etched https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-etched-datapack-compat

- Farmer's Delight https://www.curseforge.com/minecraft/mc-mods/farmers-delight https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-farmers-delight-datapack

- Buzzier Bees https://www.curseforge.com/minecraft/mc-mods/buzzier-bees https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-buzzier-bees-datapack-compat

- Ice and Fire https://www.curseforge.com/minecraft/mc-mods/ice-and-fire-dragons https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-ice-and-fire-datapack-compat

- Savage and Ravage https://www.curseforge.com/minecraft/mc-mods/savage-and-ravage https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-savage-ravage-datapack

- Better Strongholds https://www.curseforge.com/minecraft/mc-mods/yungs-better-strongholds https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-strongholds-datapack

- Better Dungeons (small dungeons) https://www.curseforge.com/minecraft/mc-mods/yungs-better-dungeons https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-dungeons-datapack

- Environmental https://www.curseforge.com/minecraft/mc-mods/environmental https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-environmental-datapack

- Blackgears Cave and Cliffs Backport (take 1.17.1 fabric rs stuff and shove it into datapack) https://www.curseforge.com/minecraft/mc-mods/caves-and-cliffs-backport https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-caves-cliffs-backport

StrangerSon71 commented 2 years ago

Suggestion: Tidbits & Rats village support.

TelepathicGrunt commented 2 years ago

@StrangerSon71 Last I checked, Rats didn’t add pieces to villages. I couldn’t find any nbt file or references to injecting pieces into villages in the codebase. But I’ll look again.

StrangerSon71 commented 2 years ago

I was sure the garbage piles still spawned in 1.16, I could be wrong though. Sorry for likely wasting your time.

TelepathicGrunt commented 2 years ago

@StrangerSon71 nah it's fine. No time is really wasted. I looked again and even tested the mod. The villages are indeed unchanged and the config files entries for village pieces are actually not even hooked up to anything. The Pet Shop villager profession is also commented out and unregistered. Maybe an older version of Rats had it? Or is there an add-on mod that re-enables them? I just want to rule out that another mod is trying to add back the village stuff to Rats.

TelepathicGrunt commented 2 years ago

Tidbits compat datapack is now made: https://github.com/TelepathicGrunt/RepurposedStructures/releases/tag/0.0.12

brisingraerowing commented 2 years ago

Rats had village structures in 1.12.2, but they were disabled in 1.14, and never reimplemented.

StrangerSon71 commented 2 years ago

@BrisingrAerowing I'm aware, I thought the Garbage Piles stuck around, I knew the Pet Shop was gone. I was wrong about the Garbage Piles.

TelepathicGrunt commented 2 years ago

Another (Low priority because it's not completely necessary) suggestion: Enhanced Mushrooms support for mushroom villages.

I'm not going to make a datapack that redesigns the mushroom village entirely to use Enchanced Mushrooms's stuff because that's a lot of work lol. But if someone else does make such a datapack, they can contact me and I can host it here on my GitHub and link it on my mod page. I'm more focusing on getting compat datapacks with other mods that redoes vanilla structures or adds pieces to vanilla structures.

StrangerSon71 commented 2 years ago

Like I said, not completely necessary. Totally understand that not being worth the work, and was pleasantly surprised about even the Better Strongholds.

dshadowwolf commented 2 years ago

I'm actually trying to figure out how to add Waystones compat myself, but there do not seem to be any documents for how to add a non-house structure to a village. There are structure files added by the mod, so it should be somewhat simple to add a non-house config for spawning a single instance of the structure in a village, but - as stated - I cannot seem to find any docs on the JSON used to define things for Repurposed Structures.

TelepathicGrunt commented 2 years ago

@brisingraerowing what minecraft version? It doesn’t matter if it is a house or not as long as the piece is small enough to fit within the side areas that road reserve and the piece has a jigsaw block at bottom facing outward with minecraft:building_entrance as the name.

Waystones did merge a pr in 1.18 to add innate compat with RS. Dunno if they released the version with compat yet

dshadowwolf commented 2 years ago

Waystones did merge a pr in 1.18 to add innate compat with RS. Dunno if they released the version with compat yet

Sadly I'm on 1.16 thanks to mod availability and part of the target group for the pack having stated that they have grown to dislike newer MC and will likely never play anything past it. I'll have to take a look and see if I can port that out, though - thanks :)

brisingraerowing commented 2 years ago

If you're asking about Rats, the village structures only exist in 1.12.2. 1.14 and later don't have them or the villagers (the Plague Doctor was changed to work like the Wandering Trader).

TelepathicGrunt commented 2 years ago

You won’t be able to port some of it because it relies on some new features I added in RS to make adding pieces to my villages easier. Though I though that waystones on 1.16 was already working with rs last I check. If not, take this 1.16.5 rs mod compat datapack, delete the structures folder, go into the pool_additions folder and change the nbt files they reference to Waystone’s structure nbt file. That should work in theory https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-simply-cats-datapack-compat

TelepathicGrunt commented 2 years ago

To help explain how that pool_additions folder works, I have this video here that may help with adding more pieces to RS villages: https://youtu.be/kzRQrQqlYjw

dshadowwolf commented 2 years ago

Though I though that waystones on 1.16 was already working with rs last I check.

I've got the "force waystones in villages" flag set, but if I go off flying around, I'm lucky if one tenth the villages I find have one when I was under the impression that setting things the way I have would generate them in every village (and does, if I turn off Repurposed Structures)

TelepathicGrunt commented 2 years ago

Ah the force spawning. Yeah that’s the feature I added in 1.18 to allow datapacks to mark pieces as a require spawn. The best you can do in 1.16 is add them with higher weights but rs villages may make more than one. Waystone’s force spawning only works on vanilla villages and not rs villages is why the config doesn’t seem to work

dshadowwolf commented 2 years ago

I turned it on to try and get any spawning at all, so... hrm... minecraft:empty for the desert-specific bit ? (I don't think any of the "mossify" existing ones would... wait - I don't see anything for desert so... blargh

dshadowwolf commented 2 years ago

okay, wtf ? Do I need to actually pull the structure from Waystones and drop it in the datapack as well? Got a message about waystones:village/common/waystone not being found - this is what is in the mod-jar (data/waystones/structures/village/common/waystone.nbt) and is what was used in the 1.18 integration... so... I'm scratching my head here.

Repurposed Structures: Failed to create valid structure with all required pieces starting from this pool file: repurposed_structures:village/swamp/town_centers. Required pieces are: [waystones:village/common/waystone]
  Make sure the max height and min height for this structure in the config is not too close together.
  If min and max height is super close together, the structure's pieces may not be able to fit in the narrow range and spawn.
  Otherwise, if the min and max height ranges aren't close and this message still appears, please report the issue to Repurposed Structures's dev with latest.log file!

This from having done as was suggested and copying the files from the simply cats datapack with the simply-cats stuff replaced.

TelepathicGrunt commented 2 years ago

@dshadowwolf I just tested in 1.16.5 with repurposed_structures_forge-3.4.7+1.16.5.jar and Waystones_1.16.5-7.6.4.jar with no datapack and setting the config to spawn in every village to true. It is working out of the box. All RS villages have a waystone except for Giant Taiga village probably due to a typo. The error you say is because I did hardcode compat with waystones in 1.16.5.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/99e8d656dbada6b85bed262e3276c092859c89be/src/main/java/com/telepathicgrunt/repurposedstructures/world/structures/pieces/StructurePiecesBehavior.java#L114-L131

I looked and I had a datapack from before that compat was added for adding waystones to rs villages. This is what it looked like: Repurposed_Structures-Waystones-1_16_5.zip

But yeah, you shouldn't need any datapack as long as you're using latest RS and latets waystones on 1.16.5 as it is already builtin within rs.

dshadowwolf commented 2 years ago

Odd... Let me go check versions, but according to the last time I had looked, I was up-to-date for both...

Okay, 3.4.7 for Repurposed Structures, 7.6.4 for Waystones - only difference from a raw install is that I have villages configured to be more frequent. There is a world I've found (randomly) that has 4 villages inside 1000 blocks of spawn that I've been re-using the seed for to do testing and it seems to never have a waystone in any - and the existing, running server world shows the same. Let me go delete the changed config and see...

freopt commented 2 years ago

Advanced peripherals?

TelepathicGrunt commented 2 years ago

@freopt does that mod add a new building to villages or change any vanilla structure?

freopt commented 2 years ago

@TelepathicGrunt yeah it adds a computer house to villages

DarthCaesium commented 2 years ago

Suggestion: YUNG's Better Mineshafts https://www.curseforge.com/minecraft/mc-mods/yungs-better-mineshafts-forge https://www.curseforge.com/minecraft/mc-mods/yungs-better-mineshafts-fabric

TelepathicGrunt commented 2 years ago

@DarthCaesium Yungs Better Mineshafts already has biome variants and the ability to create new variants with their config. So a datapack to turn RS Mineshafts into Better Mineshaft variants doesn’t make much sense which is why I never did it.

Instead, try disabling RS’s Mineshafts and try out Better Mineshaft’s config to create new variants. You may have to ask them how to work the config if it is unclear as I never tried it myself.

TelepathicGrunt commented 2 years ago

Advanced Peripherals compat is now made: https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-advanced-peripherals-compat

ENUSSOUL001 commented 2 years ago

Susgestion:Better End😎 https://www.curseforge.com/minecraft/mc-mods/betterend

TelepathicGrunt commented 2 years ago

@ENUSSOUL001 what specifically about better end should rs change to mimic or use? Their new end city style? Knowing better end, it’s probably not a jigsaw structure and thus, not able for me to turn my nether city and overworld city into the same style as their end city.

ENUSSOUL001 commented 2 years ago

oh i see ok hmm that mods is okay

ENUSSOUL001 commented 2 years ago

no better mods to fit this mod but i forgot what mods

ENUSSOUL001 commented 2 years ago

i guess i go back playing better village mod 1.18.2

ENUSSOUL001 commented 2 years ago

Last Susgestion For Now:When Dungeon Arise https://www.curseforge.com/minecraft/mc-mods/when-dungeons-arise

oh wow has a special thanks to you for toturial i didn't know that!

ENUSSOUL001 commented 2 years ago

oh wait the structures are too big

TelepathicGrunt commented 2 years ago

When dungeons arises makes entirely new structure but doesn’t change any vanilla structure.

The point of these datapacks for repurposed structures is to change RS’s structure to match the new style of a vanilla structure due to another mod (think yung’s better strongholds redesigning the strongholds).

Or datapacks to add modded village pieces to rs’s villages since the mods changed vanilla villages.

Right now, I’m waiting for yung’s better pyramid to be fully released and then I’ll make a datapack to turn rs’s pyramids to be in the same style as yung’s better pyramid.

Basically, any mod that changes a vanilla structure is what I am looking for so I can change RS to try and match the change with a datapack

ENUSSOUL001 commented 2 years ago

ah ok i see now i understand,i can find it for this okay just wait okay i find because I want to try a susgestion for this

TelepathicGrunt commented 2 years ago

Compat datapack for Yungs Better Witch Hut is now created https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-witch-huts-compat

Atlantispy commented 2 years ago

Suggestion: Domestication Innovation

Adds a petshop to villages.

TelepathicGrunt commented 2 years ago

Better desert temples done now: https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-better-desert-temples-compat

DarthCaesium commented 1 year ago

What about Pixelmon? I know it's for 1.16 now, rather than 1.18 or 1.19, but it seems like a good mod to make a datapack for.

TelepathicGrunt commented 1 year ago

Does pixelmon modify vanilla structures in any way?

DarthCaesium commented 1 year ago

It adds Pokemarts to villages

ENUSSOUL001 commented 1 year ago

hey another idea wilder wild! it's not forge, it's quilt and fabric!! maybe try forge too!!!

https://www.curseforge.com/minecraft/mc-mods/wilder-wild

TelepathicGrunt commented 1 year ago

@ENUSSOUL001 reading the mod page, it does not look like wilder wild mod does any change to vanilla structures nor adds any new pieces to vanilla structures. Thus there’s no datapack for me to make. I won’t be making modded biome specific compat datapacks because it’s too much work and there’s too many biomes mods. Not worth the time or effort. I’m busy with other stuff at the moment

ENUSSOUL001 commented 1 year ago

sheesh okay fine.... hmmmm i think i found something that change....

TelepathicGrunt commented 1 year ago

Signpost just updated to add compatibility with Repurposed Structures directly! Their signposts spawn in RS villages and can point to other RS villages https://www.curseforge.com/minecraft/mc-mods/signpost

RedBeast1959 commented 1 year ago

Hi, if you still accept suggestion for structure mod compat... I really want to recommand compat for Biome Makeover.

It changes Dark forest woodland mansion into really awesome dungeon structure. Repurposed Structure adds new types of mansion, so if Biome Makeover Compat is possible, it will be grand for challenging Biome makeover style RS mansion.

TelepathicGrunt commented 1 year ago

@RedBeast1959 Biome Makerover uses a custom structure type to do their mansion and provides no way for me to use that structure type with different pieces. It is not possible for me to make a datapack that creates new variants of their mansions in different styles. They would need to make their structure type more datapack configurable and able to take non-hardcoded pieces to use.

RedBeast1959 commented 1 year ago

@RedBeast1959 Biome Makerover uses a custom structure type to do their mansion and provides no way for me to use that structure type with different pieces. It is not possible for me to make a datapack that creates new variants of their mansions in different styles. They would need to make their structure type more datapack configurable and able to take non-hardcoded pieces to use.

Ah.... that's unfortunate... It's okay though. I love your mod :)

XxInvictus commented 1 year ago

okay, wtf ? Do I need to actually pull the structure from Waystones and drop it in the datapack as well? Got a message about waystones:village/common/waystone not being found - this is what is in the mod-jar (data/waystones/structures/village/common/waystone.nbt) and is what was used in the 1.18 integration... so... I'm scratching my head here.

Repurposed Structures: Failed to create valid structure with all required pieces starting from this pool file: repurposed_structures:village/swamp/town_centers. Required pieces are: [waystones:village/common/waystone]
  Make sure the max height and min height for this structure in the config is not too close together.
  If min and max height is super close together, the structure's pieces may not be able to fit in the narrow range and spawn.
  Otherwise, if the min and max height ranges aren't close and this message still appears, please report the issue to Repurposed Structures's dev with latest.log file!

This from having done as was suggested and copying the files from the simply cats datapack with the simply-cats stuff replaced.

I had this and I found it to be an incompatibility introduced by something that disables the MC DataFixer, do you have something like DataFixerSlayer installed or RandomPatches that has a config option to disable the DataFixer?