[1.18.2] Unsafe Park, world generation hang

[Reshy]

Thread Dump: https://pastebin.com/bCyXeiXn

"Worker-Main-8" #90 daemon prio=5 os_prio=0 cpu=149828.12ms elapsed=2684.04s tid=0x00000277d5806410 nid=0x7424 waiting on condition [0x000000a4403fd000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park(java.base@17.0.1/Native Method)

• parking to wait for <0x000000076fb16840> (a java.util.concurrent.CompletableFuture$Signaller) at java.util.concurrent.locks.LockSupport.park(java.base@17.0.1/LockSupport.java:211) at java.util.concurrent.CompletableFuture$Signaller.block(java.base@17.0.1/CompletableFuture.java:1864) at java.util.concurrent.ForkJoinPool.compensatedBlock(java.base@17.0.1/ForkJoinPool.java:3449) at java.util.concurrent.ForkJoinPool.managedBlock(java.base@17.0.1/ForkJoinPool.java:3432) at java.util.concurrent.CompletableFuture.waitingGet(java.base@17.0.1/CompletableFuture.java:1898) at java.util.concurrent.CompletableFuture.join(java.base@17.0.1/CompletableFuture.java:2117) at net.minecraft.server.level.ServerChunkCache.getChunkOffThread(minecraft@1.18.2/ServerChunkCache.java:1177) at net.minecraft.server.level.ServerChunkCache.m7587(minecraft@1.18.2/ServerChunkCache.java:1142) at net.minecraft.world.level.Level.m6522(minecraft@1.18.2/Level.java:169) at net.minecraft.world.level.Level.m46819(minecraft@1.18.2/Level.java:2086) at net.minecraft.world.level.chunk.ChunkGenerator.m208059(minecraft@1.18.2/ChunkGenerator.java:371) at net.minecraft.world.level.chunk.ChunkGenerator.m207970(minecraft@1.18.2/ChunkGenerator.java:303) at com.telepathicgrunt.repurposedstructures.misc.maptrades.StructureSpecificMaps$TreasureMapForEmeralds.getOffer(repurposed_structures@5.1.14+1.18.2/StructureSpecificMaps.java:82) at com.telepathicgrunt.repurposedstructures.misc.maptrades.StructureSpecificMaps$TreasureMapForEmeralds.m5670(repurposed_structures@5.1.14+1.18.2/StructureSpecificMaps.java:66) at net.minecraft.world.entity.npc.WanderingTrader.m7604(minecraft@1.18.2/WanderingTrader.java:131) at net.minecraft.world.entity.npc.AbstractVillager.m6616(minecraft@1.18.2/AbstractVillager.java:99) at net.minecraft.world.entity.npc.AbstractVillager.m7380(minecraft@1.18.2/AbstractVillager.java:149) at net.minecraft.world.entity.npc.WanderingTrader.m7380(minecraft@1.18.2/WanderingTrader.java:139) at net.minecraft.world.entity.Entity.m20240(minecraft@1.18.2/Entity.java:1494) at net.minecraft.world.entity.Entity.m20086(minecraft@1.18.2/Entity.java:1421) at net.minecraft.world.entity.Entity.m20223(minecraft@1.18.2/Entity.java:1428) at net.minecraft.world.level.chunk.ProtoChunk.m6286(minecraft@1.18.2/ProtoChunk.java:185) at net.minecraft.server.level.WorldGenRegion.m7967(minecraft@1.18.2/WorldGenRegion.java:318) at net.minecraft.world.level.ServerLevelAccessor$$Lambda$50921/0x0000000804f85378.accept(minecraft@1.18.2/Unknown Source) at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(java.base@17.0.1/Streams.java:411) at java.util.stream.ReferencePipeline$Head.forEach(java.base@17.0.1/ReferencePipeline.java:762) at net.minecraft.world.level.ServerLevelAccessor.m47205(minecraft@1.18.2/ServerLevelAccessor.java:11) at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate.lambda$addEntitiesToWorld$5(minecraft@1.18.2/StructureTemplate.java:426) at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate$$Lambda$50920/0x0000000804f84f48.accept(minecraft@1.18.2/Unknown Source) at java.util.Optional.ifPresent(java.base@17.0.1/Optional.java:178) at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate.addEntitiesToWorld(minecraft@1.18.2/StructureTemplate.java:418) at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate.m74536(minecraft@1.18.2/StructureTemplate.java:336) at net.minecraft.world.level.levelgen.structure.pools.SinglePoolElement.m207251(minecraft@1.18.2/SinglePoolElement.java:126) at net.minecraft.world.level.levelgen.structure.PoolElementStructurePiece.m192416(minecraft@1.18.2/PoolElementStructurePiece.java:88) at net.minecraft.world.level.levelgen.structure.PoolElementStructurePiece.m183269(minecraft@1.18.2/PoolElementStructurePiece.java:84) at net.minecraft.world.level.levelgen.structure.StructureStart.m7129(minecraft@1.18.2/StructureStart.java:53) at net.minecraft.world.level.chunk.ChunkGenerator.m211641(minecraft@1.18.2/ChunkGenerator.java:438) at net.minecraft.world.level.chunk.ChunkGenerator$$Lambda$50781/0x0000000804f52b48.accept(minecraft@1.18.2/Unknown Source) at com.google.common.collect.ImmutableList.forEach(com.google.common@31.0.1-jre/ImmutableList.java:422) at net.minecraft.world.level.chunk.ChunkGenerator.m183372(minecraft@1.18.2/ChunkGenerator.java:437) at net.minecraft.world.level.chunk.ChunkStatus.m187807(minecraft@1.18.2/ChunkStatus.java:135) at net.minecraft.world.level.chunk.ChunkStatus$$Lambda$3607/0x0000000800befac0.m183270(minecraft@1.18.2/Unknown Source) at net.minecraft.world.level.chunk.ChunkStatus.md0f5a1b$lambda$injectLightmapSetup$1$4(minecraft@1.18.2/ChunkStatus.java:546) at net.minecraft.world.level.chunk.ChunkStatus$$Lambda$3608/0x0000000800befcd8.m183270(minecraft@1.18.2/Unknown Source) at net.minecraft.world.level.chunk.ChunkStatus.m187788(minecraft@1.18.2/ChunkStatus.java:262) at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$22(minecraft@1.18.2/ChunkMap.java:589) at net.minecraft.server.level.ChunkMap$$Lambda$50610/0x0000000804f23128.apply(minecraft@1.18.2/Unknown Source) at com.mojang.datafixers.util.Either$Left.map(datafixerupper@4.1.27/Either.java:38) at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$24(minecraft@1.18.2/ChunkMap.java:587) at net.minecraft.server.level.ChunkMap$$Lambda$50566/0x0000000804f150d0.apply(minecraft@1.18.2/Unknown Source) at java.util.concurrent.CompletableFuture$UniCompose.tryFire(java.base@17.0.1/CompletableFuture.java:1150) at java.util.concurrent.CompletableFuture$Completion.run(java.base@17.0.1/CompletableFuture.java:482) at net.minecraft.server.level.ChunkTaskPriorityQueueSorter.m143188(minecraft@1.18.2/ChunkTaskPriorityQueueSorter.java:62) at net.minecraft.server.level.ChunkTaskPriorityQueueSorter$$Lambda$50608/0x0000000804f22cd8.run(minecraft@1.18.2/Unknown Source) at net.minecraft.util.thread.ProcessorMailbox.m18759(minecraft@1.18.2/ProcessorMailbox.java:91) at net.minecraft.util.thread.ProcessorMailbox.m18747(minecraft@1.18.2/ProcessorMailbox.java:146) at net.minecraft.util.thread.ProcessorMailbox.run(minecraft@1.18.2/ProcessorMailbox.java:102) at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(java.base@17.0.1/ForkJoinTask.java:1395) at java.util.concurrent.ForkJoinTask.doExec(java.base@17.0.1/ForkJoinTask.java:373) at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(java.base@17.0.1/ForkJoinPool.java:1182) at java.util.concurrent.ForkJoinPool.scan(java.base@17.0.1/ForkJoinPool.java:1655) at java.util.concurrent.ForkJoinPool.runWorker(java.base@17.0.1/ForkJoinPool.java:1622) at java.util.concurrent.ForkJoinWorkerThread.run(java.base@17.0.1/ForkJoinWorkerThread.java:165)

[TelepathicGrunt]

Check out my message here about the explorer map lag issue: https://github.com/TelepathicGrunt/RepurposedStructures/issues/266#issuecomment-1454687066

Basically, this is more of a vanilla issue where explorer maps takes extra long time to find a structure if the structure is rare and far away. As it searches, it stalls the game.

I already worked around the vanilla issue in 1.19.2 by offloading the work to a separate thread so the server/game no longer stalls. For now, in 1.18.2, you can override the wandering trader map json file I linked in my message I linked above. Then you can remove the problematic map items from trades

[Reshy]

That's good to know about Async Locator, maybe worth updating the description for 1.18.2 to install it possibly to mitigate lag?

[Reshy]

The option to disable the feature entirely seems to only work for the 1.19.2 version, checked and no version 1.18.2 so I guess I'll be doing Async Locator for certain.

[TelepathicGrunt]

There is no config option because it is in JSON and is meant to be overridden by datapack. The JSON existed in 1.18.2: https://github.com/TelepathicGrunt/RepurposedStructures/tree/1.18.2-Forge/src/main/resources/data/repurposed_structures/structure_map_trades

To disable, you make a datapack that overrides this and removes the entries. Like this: Repurposed_Structures-No_Map_Trades.zip

That's how you disable it.