search

TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
158 stars 25 forks source link

[NotABug] Pyramid generation issue #295

Closed IntMarco closed 1 year ago

IntMarco commented 1 year ago

I don't know if this is normal.

2023-08-10_10 10 51

TelepathicGrunt commented 1 year ago

This tells me nothing btw. You have to tell me exactly what biome the structure is in and more pictures around. But otherwise, pyramids will sample the land at each of their corners and average it for the height to spawn at. This way, they can get buried similar to how vanilla desert temples do. So if in the picture, some corner is super low, that would pull down the average height and bury the pyramid which is fine. The only thing i want to know more about is the biome in this area

IntMarco commented 1 year ago

Maybe it is a problem related to how structures work in Minecraft? Anyway that pyramid I sent you I don't have the world anymore (I was trying a modpack). I can send you other images that can help you, I don't know. I didn't know if it's a problem with your mod or how the structures work in Minecraft I wanted to understand it better.

IntMarco commented 1 year ago

2023-08-10_12 17 58 2023-08-10_12 20 39

At this point I think it's a Minecraft issue, right?

TelepathicGrunt commented 1 year ago

Buried desert temples in minecraft are intentional. I tried to recreate the effect by averaging the height of the land at each corner of my pyramid to spawn at. Since vanilla desert temples won’t spawn below sea level, I capped my structure to not spawn below sea level either. No bug there. Structure is spawning perfectly fine height wise.

Unless there’s something else bothering you. If so, you need to explain what it is. Cause the pictures looks fine to me.

However, the pyramid is a flower forest biome pyramid but I see snow in the first picture. Was there a flower based biome nearby or is it entirely in this snowy biome? (Hence why I wanted to know more about the biome so I can investigate why it is in the snowy biome)

TelepathicGrunt commented 1 year ago

Biomes the flower forest pyramid can spawn in: https://github.com/TelepathicGrunt/RepurposedStructures/blob/1.20-Arch/common/src/main/resources/data/repurposed_structures/tags/worldgen/biome/collections/floral.json

IntMarco commented 1 year ago

Buried desert temples in minecraft are intentional. I tried to recreate the effect by averaging the height of the land at each corner of my pyramid to spawn at. Since vanilla desert temples won’t spawn below sea level, I capped my structure to not spawn below sea level either. No bug there. Structure is spawning perfectly fine height wise.

Unless there’s something else bothering you. If so, you need to explain what it is. Cause the pictures looks fine to me.

However, the pyramid is a flower forest biome pyramid but I see snow in the first picture. Was there a flower based biome nearby or is it entirely in this snowy biome? (Hence why I wanted to know more about the biome so I can investigate why it is in the snowy biome)

Okay, I got it. Regarding the biome with snow, it's a mod that if you would like to support it would be very cool, it's called Regions Unexplored. It's a very good replacement for BYO for version 1.20.(1).