some problems i found

[peow]

first of all, great mod, im playing in fabric 1.20.1

1) RS structures can overlap vanilla structures

here a RS mansion is generated in a vanilla village

my fear with this is that some underground construction of RS will end up destroying a Stronghold portal in someone's world

2) RS structures can destroy bedrock

I found a mineshaft_nether that destroyed bedrocks underneath the nether

and as much as it may seem like it's not because of RS, I can confirm that it is, I tested the map seed using just the Fabric API, MidnightLib and Repurposed Structures

with RS:

without RS:

if you want to test it for yourself here is the seed and the coordinate:

seed: 2001851741016737369

tp: /execute in minecraft:the_nether run tp @s 356.86 -8.75 165.56 230.07 -43.92

the worst case is someone falling into the void and losing all their items

3) i think has to many piglins in nether's village or has another problem causing low fps 58 fps

191 fps after i killed 19 piglins

i made a test in a world with just Repurposed Structures and FPS Display mod

increased almost 300 fps after I killed 38 nearby piglins

if you make an update pls do to fabric 1.20.1, tx

[TelepathicGrunt]

1. This is intended and a limitation of the structure system. Vanilla woodland mansions can intersect their own villages. You can find seeds online about this so I won’t be doing any work to prevent this fusion. (Also I like fusion personally as they are rare anyway and something different to find)

2. That bedrock breaking I’ll look at but I don’t see how it is rs. Unless it is a feature spawned from the structure rather than the structure pieces themselves.

3. Piglin lowering fps is not a repurposed structures issue. That’s vanilla. You may see similar performance issue with vanilla bastions full of piglins and such but it is not game breaking and isn't unplayable tbh. If piglins are an issue in your modpack, verify you don’t have another mod causing lag with piglins and put on some rendering optimization mods if possible. The villages in nether spawns the same amount of piglins as vanilla villages spawn villagers and it is not within scope nor possible for repurposed structures to optimize piglin rendering without just removing piglins which I do not want to do. Entity rendering optimizing mods is what you'll want to use instead.

[TelepathicGrunt]

Also, no rs structure except for underground bastions even spawns on the same y level as strongholds and strongholds spawns after most structures so their end portal won’t be eaten away at

[peow]

i see, so the bedrock issue is the only problem

[TelepathicGrunt]

Bedrock issue fixed in v7.1.10. Issue wasn't the mineshafts but instead was the nether villages/outposts mainly. It has to do with "junctions" that connect the structure pieces together not being moved properly to the correct y value that rest of the structure is at.

Thank you for reporting that!

[peow]

i thank you for taking care and always updating your mod