search

TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
165 stars 26 forks source link

Remove warning log when checking basalt columns #344

Closed NattoCB closed 3 months ago

NattoCB commented 3 months ago

Dear author,

https://github.com/TelepathicGrunt/RepurposedStructures/issues/329

According to the closed issue above, this log might have been deleted already, but actually as checks, it still contains within some old branches, and sometimes it will cause the log spamming and server lagging issue.

So kindly request for merging this commit into the following branches which have not deleted this log:

Many thanks <3

TelepathicGrunt commented 3 months ago

I am not accepting pr to unsupported Mc versions. The logging is indeed important technically as it means your pack has something messing with the basalt delta and is misplacing it. You should find who is messing it up instead of silencing the logspam. That is only hiding the problem. Not solving it

NattoCB commented 3 months ago

I am not accepting pr to unsupported Mc versions. The logging is indeed important technically as it means your pack has something messing with the basalt delta and is misplacing it. You should find who is messing it up instead of silencing the logspam. That is only hiding the problem. Not solving it

Thanks for the reply, as tested it's an incompatibility issue between RS and DistantHorizens, if I remove DH and then this logs would not appear when players walking around on basalt biome

NattoCB commented 3 months ago

I am not accepting pr to unsupported Mc versions. The logging is indeed important technically as it means your pack has something messing with the basalt delta and is misplacing it. You should find who is messing it up instead of silencing the logspam. That is only hiding the problem. Not solving it

or plan to decrease the logging frequency if applicable? because once it happens the log volume is too big and usually more than hundreds of MB or more

TelepathicGrunt commented 3 months ago

Figures Distinct Horizon is still causing issues in older versions. Worse still, I reeeealy do not want to release update for older versions which would give impression I still support them when I really don't and have moved on (and CurseForge will say RS is for an older version as they list the mc version of latest file)

If I do release an update, it would only be for 1.18.2 and 1.19.2. I wont do an update for dead versions like 1.19.4

NattoCB commented 3 months ago

ok understood... thanks for letting me know the reason behind 🤝🏻