search

TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
165 stars 26 forks source link

Just Enough Resources causes Wandering Trader Error when loading / reload command #346

Open velox-resurrected opened 3 months ago

velox-resurrected commented 3 months ago

Getting the following error message for the wandering trader for a map recipe it seems.

[19:09:18] [Render thread/WARN]: Failed loading wandering trader [19:09:18] [Render thread/WARN]: Exception caught when registering wandering trader java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.Entity.m9236()" because "entity" is null at com.telepathicgrunt.repurposedstructures.misc.maptrades.StructureSpecificMaps$TreasureMapForEmeralds.m213663(StructureSpecificMaps.java:53) ~[repurposed_structures-7.1.15+1.20.1-forge.jar%231030!/:?] at jeresources.collection.TradeList.addMerchantRecipe(TradeList.java:58) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.collection.TradeList.addITradeList(TradeList.java:69) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.entry.AbstractVillagerEntry.addITradeLists(AbstractVillagerEntry.java:29) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.entry.AbstractVillagerEntry.(AbstractVillagerEntry.java:22) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.entry.WanderingTraderEntry.(WanderingTraderEntry.java:16) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.util.VillagersHelper.initRegistry(VillagersHelper.java:30) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.compatibility.Compatibility.init(Compatibility.java:33) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.proxy.CommonProxy.initCompatibility(CommonProxy.java:14) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at jeresources.jei.JEIConfig.registerCategories(JEIConfig.java:98) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23895!/:1.4.0.247] at mezz.jei.library.load.PluginLoader.lambda$createRecipeCategories$3(PluginLoader.java:91) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.library.load.PluginCaller.callOnPlugins(PluginCaller.java:25) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.library.load.PluginLoader.createRecipeCategories(PluginLoader.java:91) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.library.load.PluginLoader.createRecipeManager(PluginLoader.java:121) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.library.startup.JeiStarter.start(JeiStarter.java:130) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.forge.startup.StartEventObserver.transitionState(StartEventObserver.java:130) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.forge.startup.StartEventObserver.restart(StartEventObserver.java:109) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at mezz.jei.forge.startup.StartEventObserver.onEvent(StartEventObserver.java:96) ~[jei-1.20.1-forge-15.12.3.55.jar%23889!/:15.12.3.55] at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar%2387!/:?] at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar%2387!/:?] at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%2387!/:?] at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%2387!/:?] at net.minecraftforge.client.ForgeHooksClient.onRecipesUpdated(ForgeHooksClient.java:717) ~[forge-1.20.1-47.3.6-universal.jar%231141!/:?] at net.minecraft.client.multiplayer.ClientPacketListener.m6327(ClientPacketListener.java:1354) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.network.protocol.game.ClientboundUpdateRecipesPacket.m5797(ClientboundUpdateRecipesPacket.java:32) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.network.protocol.game.ClientboundUpdateRecipesPacket.m5797(ClientboundUpdateRecipesPacket.java:14) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.network.protocol.PacketUtils.m263899(PacketUtils.java:22) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.util.thread.BlockableEventLoop.m6367(BlockableEventLoop.java:156) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(ReentrantBlockableEventLoop.java:23) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.util.thread.BlockableEventLoop.m7245(BlockableEventLoop.java:130) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.util.thread.BlockableEventLoop.m18699(BlockableEventLoop.java:115) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.client.Minecraft.m91383(Minecraft.java:1106) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.client.Minecraft.m91374(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%231136!/:?] at net.minecraft.client.main.Main.main(Main.java:218) ~[forge-47.3.6.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?] at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.3.6.jar:?] at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.3.6.jar:?] at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.3.6.jar:?] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?] at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?]

TelepathicGrunt commented 3 months ago

Jei resources may be passing a null entity to the trade system which crashes. They will likely need to adjust their code. See if there is a report already on JER repo

TelepathicGrunt commented 3 months ago

yeah I don't think this is an RS issue. More likely to be JER https://github.com/TelepathicGrunt/RepurposedStructures/blob/8f8e9a7a456389530520235fb956fa02a32e1595/common/src/main/java/com/telepathicgrunt/repurposedstructures/misc/maptrades/StructureSpecificMaps.java#L53