Replies showing up as new messages

ghost commented 7 years ago

I have telegram running on my phone and also connected to my Plasma desktop via your telepathy-morse packages.

When I reply to a message via my phone, I get a pop-up notification of that message on my desktop. Surely only genuine replies should pop-up as notifications?

ghost commented 7 years ago

telepathy-morse-br

Kaffeine commented 7 years ago

The problem is that there is little to no workaround. Someone wants to have 'cross-device' conversation, someone like you wants to have no stupid pop-ups. There is no way to control notifications in telepathy, so I can not disable pop-up for your messages or messages that you already read on another device.

The proper solution would be to implement service-side logging in telepathy, so telepathy-morse will get the messages, but will not raise a UI for anything and everything.

The best thing I can do for now is filter out messages from yourself, if there is no active channel yet. You'll still get notifications about replies, so it would not help much.

Kaffeine commented 7 years ago

https://github.com/TelepathyIM/telepathy-morse/commit/748c7908ef70d9999afd77be7b007e9573bfdd2a

ghost commented 7 years ago

Let me kick off a rebuild on KCI and Ill test that commit :)

Kaffeine commented 7 years ago

I'm going to test the commit as soon as my TelepathyQt rebuild completed. :)

I hope it will make the client a bit less annoying.

ghost commented 7 years ago

Another little issue is history. It doesn't seem to recognise who said what :/

Kaffeine commented 7 years ago

You are using KDE Telepathy, right? There is a number of issues in Telepathy client and I can help with KDE or Sailfish OS ones.

ghost commented 7 years ago

yes, KDE on Kubuntu 17.10

Kaffeine commented 7 years ago

The commit seems to work as intended, so I'm going to push it soon.

ghost commented 7 years ago

ah shoot, I rebuilt using master and your fix is in wip_noNewChannelForMessageFromSelf

face palms

would you mind pushing to master?

Kaffeine commented 7 years ago

would you mind pushing to master?

Done

ghost commented 7 years ago

That's a lot better, thank you :)

ghost commented 7 years ago

any ETA on when 0.2.0 will be released?

Kaffeine commented 7 years ago

@CliffordD

Another little issue is history. It doesn't seem to recognise who said what :/

I just recall what was been the problem: it is ktp-otr-proxy messing up all incoming messages. There are a number of issues and I didn't find a way to fix any of them without significant rewrite. Locally I just disabled the proxy; sadly it can only be disabled at build time by modifying CMakeLists file. If you disable it via UI, it still bypass and corrupt messages. :-(

Kaffeine commented 7 years ago

@CliffordD

any ETA on when 0.2.0 will be released?

It will take me 25-45 hours to complete the release. I will spend 1-2 hours per working days and 12-16 hours per weekends, so the realistic plan is to have release in two weeks. Also, my experience says that it is better to make release at Monday. If there will be no surprises, we'll have the release by 17 [July.]

TODO:

Must-have:

28 (Add Telegram Channels support) is done, I test and polish it for two weeks now. I would like to push it with #51;
54 (Publish release for Sailfish OS on OpenRepos.net) is not started. I have no idea, but may be it will take 4-6 hours. I already have builds on merproject.org.

Planned:
39 (Mute a group chat) is not started, requires 1-2 hours; the backend part is already done;
44 (Contact media) is done for incoming messages, requires 1-2 extra hours for testing;
51 (Expose broadcast channels as 1-to-1 chat) is WIP, 6-10 hours remaining. I want to have avatars and I implemented peer pictures for testApp but would like to come with a better solution for Morse;
52 (Expose dialogues contacts instead of contact list) is WIP, requires 4-8 hours for to be completed;
53 (Add proxy support) is not started, requires 1-2 hours; the backend part is already done;

Not planned:
27 (Contact search) is done (wip_contactSearch), but will not be merged until I find a capable client and test it. It seems that none of KTP or Empathy support it, so I feel free to move this to 0.3.0.

After that I'll need 2-3 hours to update README(s) and upload the release(s) as RC1. Finally, I should write a blog post to attract more users and developers. The post can take 4-12 hours. After that I will upload the final 0.2.0 and publish the blog post.

Thaodan commented 7 years ago

Do you mean replies show up as new messages from you or the other user? Cause I go a simlar issue just with that the messages appear as the other user im chatting with.

Kaffeine commented 7 years ago

@Thaodan , I think it is the issue with KDE Telepathy (ktp-otr-proxy corrupts message sender) https://github.com/TelepathyIM/telepathy-morse/issues/48#issuecomment-311467015

Kaffeine commented 4 years ago

Some more work on this in KTp:

TelepathyIM / telepathy-morse

Replies showing up as new messages #48

TODO:

Must-have:

28 (Add Telegram Channels support) is done, I test and polish it for two weeks now. I would like to push it with #51;

54 (Publish release for Sailfish OS on OpenRepos.net) is not started. I have no idea, but may be it will take 4-6 hours. I already have builds on merproject.org.

Planned:

39 (Mute a group chat) is not started, requires 1-2 hours; the backend part is already done;

44 (Contact media) is done for incoming messages, requires 1-2 extra hours for testing;

51 (Expose broadcast channels as 1-to-1 chat) is WIP, 6-10 hours remaining. I want to have avatars and I implemented peer pictures for testApp but would like to come with a better solution for Morse;

52 (Expose dialogues contacts instead of contact list) is WIP, requires 4-8 hours for to be completed;

53 (Add proxy support) is not started, requires 1-2 hours; the backend part is already done;

Not planned:

27 (Contact search) is done (wip_contactSearch), but will not be merged until I find a capable client and test it. It seems that none of KTP or Empathy support it, so I feel free to move this to 0.3.0.