search

TelepathyIM / wocky

Wocky XMPP library
GNU Lesser General Public License v2.1
3 stars 3 forks source link

XEP-0198 Stream Management #16

Open rufferson opened 3 years ago

rufferson commented 3 years ago

Stream Management for Wocky

The MR does R/Ack and resumption and this core functionality seems to be working (SMACK/Resume).

The design is more or less described in the issue #14

The changes are breaking (for gabble) therefore require api version bump. Breaking changes are because wocky-porter by default will do automatic re-connection (if SM is discovered) which in case of soft-fail (not-found) would cause re-bind, hence changing full-jid to which gabble remains oblivious.

Closes #14

P.S. I'll park this till I complete gabble part as it may need api/logic update.

rufferson commented 3 years ago

That should be ready for merge now afaic. Will let it stay for a while in case anyone wants to review.

It would still probably make sense to add a timeout to avoid firewall blackout (as simple as a threshold for unanswered r number, no timers) but I'll leave it for the future improvements.