Telerik-Verified-Plugins / ImagePicker

Cordova Plugin For Multiple Image Selection
MIT License
182 stars 331 forks source link

iOS freezes when calling getPictures #173

Open cerealexx opened 5 years ago

cerealexx commented 5 years ago

Tested on an iPad with iOS 13.2.3.

When calling getPictures the plugin shows the permission modal and then freezes on tapping on allow. Any additional tries after giving permission result in same app freezing.

I'm using plugin version 2.3.3

Sharad2390 commented 5 years ago

Hi,

I am also facing the same issue while using iPad with iOS 13.2.3.

By using this plugin, when I am trying to accessing my iPad gallery, my complete app got frozen.

Sharad2390 commented 5 years ago

Also, I am going to share my findings:

  1. While creating iOS build using Xcode 10.1 and install IPA using test flight on the same iPad ( OS version 13.2.3 ), getPictures function working fine and able to open gallery.
  2. While creating iOS build using Xcode 11.2.1 and install IPA using test flight on the same iPad ( OS version 13.2.3 ), getPictures function not working fine and not able to open gallery.

Maybe this will help you guys to resolve this issue.

deliverymanager commented 5 years ago

+1

anujraghuvanshi commented 5 years ago

@cerealexx @Sharad2390 - For the time being we are looking at this. You can pass disable_popover => true to getPictures() function and you will be able to access things(photos) in a different way.

Thanks for your patience.

deliverymanager commented 5 years ago

This worked for me. But the buttons on the top are not translated properly. I mean it shows "picker.navigation.cancel-button" on the left and on the right "picker.navigation.done-button"

Besides that it works

anujraghuvanshi commented 5 years ago

@deliverymanager - Kindly share system(device) information here So we can dig into it?

cerealexx commented 5 years ago

Worked for me too. Thanks!

deliverymanager commented 5 years ago

Here is my system info: IMG_75DDDD6A0BB0-1

Screenshot 2019-11-28 08 42 36

Screenshot 2019-11-28 08 40 00
Sharad2390 commented 5 years ago

Thanks for your reply.

I have put disable_popover: true in options at getPictures function. Now, it is working fine for me.

anujraghuvanshi commented 5 years ago

Here is my system info: IMG_75DDDD6A0BB0-1

Screenshot 2019-11-28 08 42 36

Screenshot 2019-11-28 08 40 00

@deliverymanager - Which language you are using in your device as default ?

deliverymanager commented 5 years ago

Greek or "el" as a language code.

anujraghuvanshi commented 5 years ago

Greek or "el" as a language code. @deliverymanager - We have not supported Greek that's the reason you are getting this. It works fine for English.

deliverymanager commented 5 years ago

How can I help to make the translations for Greek language? Could you please send me the language file with the english phrases? Or just some important phrases, so that I can translate them?

benjamineberle commented 4 years ago

The workaround with disable_popover works on iPad, but not iPhone. Getting this exception

Screenshot 2019-12-10 at 11 56 42
benjamineberle commented 4 years ago

Actually it only crashes on iOS 13.2.3 (iPhone Xr) but works fine on an older iOS 13.1.x (iPhone 7)

maxymczech commented 4 years ago

Getting the same error. The suggested fix with disable_popover works, tested on iPad only.

benjamineberle commented 4 years ago

Actually it only crashes on iOS 13.2.3 (iPhone Xr) but works fine on an older iOS 13.1.x (iPhone 7)

Seems it's hardware related, works on iOS 13.3 on iPhone 7. On Xr it only works the first time after I install it. Second time it crashes.

andreyqin commented 4 years ago

Looks like the root cause of the issue is that starting from iOS 13 you have to specify UIPopoverPresentationController.sourceRect which is commented out in the source code now. I just set it to appear like this popPC.sourceRect = CGRectMake(0, 0, 0, 0); (top left corner) and it started to work even if disable_popover is false.

KreativeKoder commented 4 years ago

Thank you andreyqin. This is the solution that worked for me!

benjamineberle commented 4 years ago

Is there a branch or PR with that fix? I'm a noob in Objective C unfortunately...

This line?

Screenshot 2020-02-19 at 12 32 29
andreyqin commented 4 years ago

@benjamineberle yes, correct. The only disadvantage of this solution is that your popover will appear at the top left corner of the screen which may be confusing for users. Unfortunately, I wasn't been able to find a way to center it, some found solutions worked in a completely different way, not as they supposed to be working.