search

Telerik-Verified-Plugins / LocalNotification

Apache License 2.0
21 stars 27 forks source link

iOS 10 support? #16

Closed frigon closed 7 years ago

frigon commented 7 years ago

I've got the same code running on a ios10 and ios9 device and notifications don't show up in the notification area in iOS 10. Is this not supported or is it possible a bug in iOS 10?

Scalpweb commented 7 years ago

This plugin comes from a fork, and a PR has been sent to the initial version to fix this issue.

You can check it out here : https://github.com/katzer/cordova-plugin-local-notifications/pull/1093

So what you need to do is to remove the telerik version of the plugin from you version and add the initial one (from Katzer), then apply the fixes from the PR. It's working on my side.

Scalpweb commented 7 years ago

Nevermind... Not possible with Telerik, as they do not accept "10.0" as iOS target version. So it will not compile.

Eolus commented 7 years ago

Any progress on getting iOS 10 support added? This has broken an important feature for iOS 10 users.

0.8.4 installs fine on iOS 10 and accepts schedule requests, but never delivers any notifications. The katzer ios 10 branch mentioned above will not build, so we are stuck for the moment.

EddyVerbruggen commented 7 years ago

That fork is for adding the new iOS 10 way of adding notifications to the plugin, however the current way should work just fine as it's only deprecated and will probably work fine for a few major iOS releases to come (as with all things Apple deprecated, luckily).

So there must be something else going on and I suspect it to be the repeat interval logic as that's what I had to fix on my NativeScript plugin recently as well.

EddyVerbruggen commented 7 years ago

Fixed in 0.8.4.1. It was indeed a problem with the repeat logic which Apple changed a bit for iOS 10. Easy fix, hard to find. Also sent a PR to the Katzer upstream repo.

Eolus commented 7 years ago

Eddy - Thanks for the quick response - that did the trick!