Telerik-Verified-Plugins / LocalNotification

Apache License 2.0
21 stars 27 forks source link

Plans to merge changes from katzer master branch? #29

Open dherbe opened 6 years ago

dherbe commented 6 years ago

Hi there,

Is it possible to let us know when this fork will merge the latest updates and new features from the original branch? Therefor allowing us to update the plugin from the Telerik App builder.

Thank you

EddyVerbruggen commented 6 years ago

Hi, is there any specific element that's missing in this fork? And what is stopping you from using the upstream repo?

Thanks for the clarification!

dherbe commented 6 years ago

I've always used this plugin, installed and updated from the Plugins Marketplace. I can use the upstream repo, but I'm guessing I will have to maintain further updates manually right?

dherbe commented 6 years ago

Missing in this fork, are the new updates which include ability to have actions and inputs and other local notifications customisation.

EddyVerbruggen commented 6 years ago

OK, the problem is I'm not able to spend more than a few minutes on this task, so if you can confirm swapping out this fork for the upstream won't break your app then I'll happily merge the changes and you can swap back. Does that work for you?

dherbe commented 6 years ago

Yes sure. I'll do it and let you know later then. Thanks Eddy

dherbe commented 6 years ago

Hey, Just to let you know

It seems it might give a bit more work.

I've tried to install the plugin from the upstream repo and awkwardly I got something for the first since I use Telerik Platform.

image

EddyVerbruggen commented 6 years ago

Could be there's stuff in the archive that's blacklisted. .git folder or .DS_Store files. Just guessing..

dherbe commented 6 years ago

Thanks for the tip but no, I don't see any of such folders or files in the archive.