search

Telerik-Verified-Plugins / Mapbox

Native OpenGL maps for your Cordova app
112 stars 52 forks source link

How do you Update IOS SDK? #58

Open lbweb opened 8 years ago

lbweb commented 8 years ago

Hi All, In a separate pull request listed by @dagatsoin here he says:

"The Mapbox SDK is now iOS 3.2.0 and also fixes a memory leak which add 30-50mo each time the user show/hide the map"

I am having this exact issue! Can someone explain how to update the IOS SDK sitting behind the Telerik plugin to 3.20?

Please note: I am using @anothar's fork here

risinghero commented 8 years ago

Hi, @lbweb . You can look at @dagatsoin commit changes and try to change the same way. But I don't recommend for the following reason: I was unable to make .framework work. So it's better to wait for @dagatsoin answer whether it works or try his fork. If it works it' s not so hard to integrate his code regarding version. If not - it will be painful. I'll have to remember how to compile .framework into library and it will take time.

dagatsoin commented 8 years ago

@lbweb I can't make a better answer than @anothar. Just take a look to my commit. As I remember I did not compile anything, I just downloaded the sdk from here then declared the new frameworks and the needed files in plugin.xml. Cordova did the rest.

lbweb commented 8 years ago

@anothar @dagatsoin Thanks guys! Will investigate further and update this thread.

lbweb commented 7 years ago

HI @dagatsoin, In terms of upgrading the IOS Mapbox SDK to 3.20 (as discussed above) - I've followed your commit listed but I'm getting one last build error which I can't get to the bottom of!

It has to do with the CDVMapbox.m file - I checked the file and all the other files its trying to import are also there. Can you point me in the right direction on what could be going wrong here? Did you have a similar error when you upgraded the underlying SDK to 3.2?

The following build commands failed: CompileC build/BPMap2.build/Debug-iphonesimulator/BPMap2.build/Objects-normal/i386/CDVMapbox.o BPMap2/Plugins/cordova-plugin-mapbox/CDVMapbox.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler

dagatsoin commented 7 years ago

ouch... I haven't got a clue as to what the hell is this. And no, I had not got this error. My 2 cts:

cusspvz commented 7 years ago

Planing to update iOS, don't know to which version yet. Not only because of this issue, but because I've experienced runtime delays on iOS 10.2.x.

Adding it to the next milestone.

@dagatsoin @EddyVerbruggen Do you know in advance which version should we choose without breaking changes on the API we're using?