search

Telerik-Verified-Plugins / SecureHTTP

Cordova / Phonegap plugin for communicating with HTTP servers. Allows for SSL pinning!
MIT License
33 stars 31 forks source link

android: acceptAllCerts doesn't call callbacks #7

Closed denisbabineau closed 9 years ago

denisbabineau commented 9 years ago

As per API/doc, acceptAllCerts should call one of its success/failure callback but it's not doing so. At least on android, the CordovaHttpPlugin's execute method is not calling success()/error() on callbackContext for the "acceptAllCerts" as it is doing for the "enableSSLPinning" case.

EddyVerbruggen commented 9 years ago

You're right, it didn't on Android. It will now invoke the success handler once it's done.

denisbabineau commented 9 years ago

awesome, thanks!