search

TeliaSoneraNorge / telia-terraform-modules

Terraform modules for creating cloud infrastucture
MIT License
9 stars 7 forks source link

Remove duplicated variables for ALB and dynamodb-table module #49

Closed antonbabenko closed 6 years ago

antonbabenko commented 6 years ago

Reverts #12 and #28 as described here - https://github.com/TeliaSoneraNorge/telia-terraform-modules/pull/12#issuecomment-387315287

antonbabenko commented 6 years ago

Yes, it fails in places where these modules are being used and in CircleCI.

antonbabenko commented 6 years ago

These modules are being used by terragrunt, which runs hooks before init and copying declaration for those variables. terraform init or terragrunt init will fail unless there is the same hook run by Concourse.

colincoleman commented 6 years ago

OK - I will approve now and add a ticket to see what we can do to get it pass concourse tests going forward