TelloViz / Card-Collection

Project for CPSC 362 Software Engineering
0 stars 3 forks source link

Fixed wrong parameter name passed to construct_query #118

Closed TelloViz closed 1 month ago

TelloViz commented 1 month ago

The file was approved previously, then I found an error.

This line:

        return Backend.construct_query(tupleList)

Should have been this:

        return Backend.construct_query(search_parameters)

@CRam-irez make sure to pay attention to the actual parameter name being passed to the function you are ipmlementing. See the signature of the function:

    def handle_search(self, search_parameters: list[tuple[str, str, str]]) -> list[Card]:
CRam-irez commented 1 month ago

sorry about that, i will make sure i read everything and pay closer attention to the outlines

TelloViz commented 1 month ago

@CRam-irez No worries, I already fixed it, yu can see that in the history here in this thread. I reopened PR for you to review and approve or request chagnes.