TelluIoT / ThingML

The ThingML modelling language
https://github.com/TelluIoT/ThingML
Apache License 2.0
101 stars 32 forks source link

Make ThingML thread safe #190

Closed jakhog closed 5 years ago

jakhog commented 6 years ago

There are some methods/classes that are currently not thread safe. E.g. ThingMLCompiler.loadModel(...), and I'm guessing many more.

IMHO we should aim for thread safety in the compilers (not the EMF models and other dependencies).

My specific problem right now is that I try to run the tests in threads, and if I call loadModel at the same time in 8 threads, I get a random set of 8 models returned.

fungiboletus commented 6 years ago

Just run 8 VMs instead of 8 threads. 🏖

Le 1 août 2017 12:29 PM, "Jakob Høgenes" notifications@github.com a écrit :

There are some methods/classes that are currently not thread safe. E.g. ThingMLCompiler.loadModel(...), and I'm guessing many more.

IMHO we should aim for thread safety in the compilers (not the EMF models and other dependencies).

My specific problem right now is that I try to run the tests in threads, and if I call loadModel at the same time in 8 threads, I get a random set of 8 models returned.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TelluIoT/ThingML/issues/190, or mute the thread https://github.com/notifications/unsubscribe-auth/AACyrP_S9reyNbqlB52lJnrZNE0wzMrdks5sTv38gaJpZM4Oph6R .